Title: [131391] trunk/Source/WebCore
- Revision
- 131391
- Author
- [email protected]
- Date
- 2012-10-15 17:53:31 -0700 (Mon, 15 Oct 2012)
Log Message
Remove page visibility hidden histograms
https://bugs.webkit.org/show_bug.cgi?id=99360
Reviewed by Ojan Vafai.
The 2 page visibility hidden histograms were added in http://webkit.org/b/85537 to
investigate a potential optimization where we would destroy the render tree when
a tab was hidden. The optimization was abandoned but the histograms were never
removed. They are too narrow to be reused so this change removes them.
* page/Page.cpp:
(WebCore::Page::setVisibilityState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131390 => 131391)
--- trunk/Source/WebCore/ChangeLog 2012-10-16 00:48:06 UTC (rev 131390)
+++ trunk/Source/WebCore/ChangeLog 2012-10-16 00:53:31 UTC (rev 131391)
@@ -1,3 +1,18 @@
+2012-10-15 Julien Chaffraix <[email protected]>
+
+ Remove page visibility hidden histograms
+ https://bugs.webkit.org/show_bug.cgi?id=99360
+
+ Reviewed by Ojan Vafai.
+
+ The 2 page visibility hidden histograms were added in http://webkit.org/b/85537 to
+ investigate a potential optimization where we would destroy the render tree when
+ a tab was hidden. The optimization was abandoned but the histograms were never
+ removed. They are too narrow to be reused so this change removes them.
+
+ * page/Page.cpp:
+ (WebCore::Page::setVisibilityState):
+
2012-10-15 Ryuan Choi <[email protected]>
REGRESSION: Build break after r131373 when ACCELERATED_COMPOSITING disabled
Modified: trunk/Source/WebCore/page/Page.cpp (131390 => 131391)
--- trunk/Source/WebCore/page/Page.cpp 2012-10-16 00:48:06 UTC (rev 131390)
+++ trunk/Source/WebCore/page/Page.cpp 2012-10-16 00:53:31 UTC (rev 131391)
@@ -44,7 +44,6 @@
#include "FrameTree.h"
#include "FrameView.h"
#include "HTMLElement.h"
-#include "HistogramSupport.h"
#include "HistoryItem.h"
#include "InspectorController.h"
#include "InspectorInstrumentation.h"
@@ -1121,14 +1120,8 @@
return;
m_visibilityState = visibilityState;
- if (!isInitialState && m_mainFrame) {
- if (visibilityState == PageVisibilityStateHidden) {
- ArenaSize size = renderTreeSize();
- HistogramSupport::histogramCustomCounts("WebCore.Page.renderTreeSizeBytes", size.treeSize, 1000, 500000000, 50);
- HistogramSupport::histogramCustomCounts("WebCore.Page.renderTreeAllocatedBytes", size.allocated, 1000, 500000000, 50);
- }
+ if (!isInitialState && m_mainFrame)
m_mainFrame->dispatchVisibilityStateChangeEvent();
- }
#endif
#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
