Modified: trunk/Source/WebCore/ChangeLog (131442 => 131443)
--- trunk/Source/WebCore/ChangeLog 2012-10-16 12:05:02 UTC (rev 131442)
+++ trunk/Source/WebCore/ChangeLog 2012-10-16 12:13:55 UTC (rev 131443)
@@ -1,3 +1,19 @@
+2012-10-16 Luke Macpherson <[email protected]>
+
+ Handle CSSPropertyOpacity in StyleBuilder.
+ https://bugs.webkit.org/show_bug.cgi?id=99418
+
+ Reviewed by Alexis Menard.
+
+ One small step in moving from the huge switch in StyleResolver::applyProperty() to the StyleBuilder approach.
+
+ Covered by many existing tests, for example fast/text/complex-text-opacity.html.
+
+ * css/StyleBuilder.cpp:
+ (WebCore::StyleBuilder::StyleBuilder):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::applyProperty):
+
2012-10-16 Kent Tamura <[email protected]>
Fix some appearance glitches of multiple fields input elements
Modified: trunk/Source/WebCore/css/StyleBuilder.cpp (131442 => 131443)
--- trunk/Source/WebCore/css/StyleBuilder.cpp 2012-10-16 12:05:02 UTC (rev 131442)
+++ trunk/Source/WebCore/css/StyleBuilder.cpp 2012-10-16 12:13:55 UTC (rev 131443)
@@ -1887,6 +1887,7 @@
setPropertyHandler(CSSPropertyMaxWidth, ApplyPropertyLength<&RenderStyle::maxWidth, &RenderStyle::setMaxWidth, &RenderStyle::initialMaxSize, AutoEnabled, LegacyIntrinsicEnabled, IntrinsicEnabled, NoneEnabled, UndefinedEnabled>::createHandler());
setPropertyHandler(CSSPropertyMinHeight, ApplyPropertyLength<&RenderStyle::minHeight, &RenderStyle::setMinHeight, &RenderStyle::initialMinSize, AutoEnabled, LegacyIntrinsicEnabled, IntrinsicDisabled>::createHandler());
setPropertyHandler(CSSPropertyMinWidth, ApplyPropertyLength<&RenderStyle::minWidth, &RenderStyle::setMinWidth, &RenderStyle::initialMinSize, AutoEnabled, LegacyIntrinsicEnabled, IntrinsicEnabled>::createHandler());
+ setPropertyHandler(CSSPropertyOpacity, ApplyPropertyDefault<float, &RenderStyle::opacity, float, &RenderStyle::setOpacity, float, &RenderStyle::initialOpacity>::createHandler());
setPropertyHandler(CSSPropertyOrphans, ApplyPropertyDefault<short, &RenderStyle::orphans, short, &RenderStyle::setOrphans, short, &RenderStyle::initialOrphans>::createHandler());
setPropertyHandler(CSSPropertyOutline, ApplyPropertyExpanding<SuppressValue, CSSPropertyOutlineWidth, CSSPropertyOutlineColor, CSSPropertyOutlineStyle>::createHandler());
setPropertyHandler(CSSPropertyOutlineColor, ApplyPropertyColor<NoInheritFromParent, &RenderStyle::outlineColor, &RenderStyle::setOutlineColor, &RenderStyle::setVisitedLinkOutlineColor, &RenderStyle::color>::createHandler());
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (131442 => 131443)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-10-16 12:05:02 UTC (rev 131442)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-10-16 12:13:55 UTC (rev 131443)
@@ -3235,9 +3235,6 @@
m_style->setBoxReflect(reflection.release());
return;
}
- case CSSPropertyOpacity:
- HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(opacity, Opacity)
- return;
case CSSPropertySrc: // Only used in @font-face rules.
return;
case CSSPropertyUnicodeRange: // Only used in @font-face rules.
@@ -3724,6 +3721,7 @@
case CSSPropertyMaxWidth:
case CSSPropertyMinHeight:
case CSSPropertyMinWidth:
+ case CSSPropertyOpacity:
case CSSPropertyOrphans:
case CSSPropertyOutline:
case CSSPropertyOutlineColor:
