Title: [131447] trunk/Source/WebKit2
- Revision
- 131447
- Author
- [email protected]
- Date
- 2012-10-16 06:09:55 -0700 (Tue, 16 Oct 2012)
Log Message
[WK2][EFL] Crash in _ewk_view_on_favicon_changed()
https://bugs.webkit.org/show_bug.cgi?id=99454
Patch by Sudarsana Nagineni <[email protected]> on 2012-10-16
Reviewed by Kenneth Rohde Christiansen.
Added missing null check to avoid a crash if the current URL of
view is NULL.
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_on_favicon_changed):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (131446 => 131447)
--- trunk/Source/WebKit2/ChangeLog 2012-10-16 12:53:21 UTC (rev 131446)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-16 13:09:55 UTC (rev 131447)
@@ -1,3 +1,16 @@
+2012-10-16 Sudarsana Nagineni <[email protected]>
+
+ [WK2][EFL] Crash in _ewk_view_on_favicon_changed()
+ https://bugs.webkit.org/show_bug.cgi?id=99454
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added missing null check to avoid a crash if the current URL of
+ view is NULL.
+
+ * UIProcess/API/efl/ewk_view.cpp:
+ (_ewk_view_on_favicon_changed):
+
2012-10-16 Mikhail Pozdnyakov <[email protected]>
[WK2] Provide WKURL API for resolving the relative URL with the given base URL
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (131446 => 131447)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-16 12:53:21 UTC (rev 131446)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-10-16 13:09:55 UTC (rev 131447)
@@ -261,7 +261,7 @@
Evas_Object* ewkView = static_cast<Evas_Object*>(eventInfo);
const char* view_url = ewk_view_url_get(ewkView);
- if (strcasecmp(view_url, pageURL))
+ if (!view_url || strcasecmp(view_url, pageURL))
return;
ewk_view_update_icon(ewkView);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
