Title: [131572] trunk
- Revision
- 131572
- Author
- [email protected]
- Date
- 2012-10-17 02:57:57 -0700 (Wed, 17 Oct 2012)
Log Message
Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
https://bugs.webkit.org/show_bug.cgi?id=99566
Reviewed by Kent Tamura.
Source/WebCore:
It had a too optimistic assertion. This change removes it.
Test: fast/forms/textarea/textarea-autofocus-removal-while-focusing.html
* html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback):
LayoutTests:
* fast/forms/textarea/textarea-autofocus-removal-while-focusing.txt: Added.
* fast/forms/textarea/textarea-autofocus-removal-while-focusing.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131571 => 131572)
--- trunk/LayoutTests/ChangeLog 2012-10-17 09:43:48 UTC (rev 131571)
+++ trunk/LayoutTests/ChangeLog 2012-10-17 09:57:57 UTC (rev 131572)
@@ -1,3 +1,13 @@
+2012-10-17 MORITA Hajime <[email protected]>
+
+ Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
+ https://bugs.webkit.org/show_bug.cgi?id=99566
+
+ Reviewed by Kent Tamura.
+
+ * fast/forms/textarea/textarea-autofocus-removal-while-focusing.txt: Added.
+ * fast/forms/textarea/textarea-autofocus-removal-while-focusing.html: Added.
+
2012-10-17 Anton Muhin <[email protected]>
Unreviewed Chromium rebaselines.
Added: trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing-expected.txt (0 => 131572)
--- trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing-expected.txt 2012-10-17 09:57:57 UTC (rev 131572)
@@ -0,0 +1 @@
+PASS unless crash.
Added: trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing.html (0 => 131572)
--- trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing.html (rev 0)
+++ trunk/LayoutTests/fast/forms/textarea/textarea-autofocus-removal-while-focusing.html 2012-10-17 09:57:57 UTC (rev 131572)
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script>
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+var textarea = document.createElement("textarea");
+textarea.setAttribute("autofocus", "");
+textarea.addEventListener("DOMFocusIn", function () { document.documentElement.innerHTML = ""; }, false);
+document.documentElement.appendChild(textarea);
+window.setTimeout(function() {
+ document.body.innerHTML = "PASS unless crash.";
+ testRunner.notifyDone();
+}, 0);
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (131571 => 131572)
--- trunk/Source/WebCore/ChangeLog 2012-10-17 09:43:48 UTC (rev 131571)
+++ trunk/Source/WebCore/ChangeLog 2012-10-17 09:57:57 UTC (rev 131572)
@@ -1,3 +1,17 @@
+2012-10-17 MORITA Hajime <[email protected]>
+
+ Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback()
+ https://bugs.webkit.org/show_bug.cgi?id=99566
+
+ Reviewed by Kent Tamura.
+
+ It had a too optimistic assertion. This change removes it.
+
+ Test: fast/forms/textarea/textarea-autofocus-removal-while-focusing.html
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::updateFromElementCallback):
+
2012-10-17 Vsevolod Vlasov <[email protected]>
Web Inspector: When dirty uiSourceCode is saved to disk from scripts navigator context menu working copy is not committed.
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (131571 => 131572)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-10-17 09:43:48 UTC (rev 131571)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-10-17 09:57:57 UTC (rev 131572)
@@ -297,7 +297,6 @@
{
ASSERT_ARG(node, node->isElementNode());
ASSERT_ARG(node, static_cast<Element*>(node)->isFormControlElement());
- ASSERT(node->renderer());
if (RenderObject* renderer = node->renderer())
renderer->updateFromElement();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
