[webkit-changes] [131576] trunk/Source/WebKit/efl

Wed, 17 Oct 2012 03:07:39 -0700

Title: [131576] trunk/Source/WebKit/efl
Revision
131576
Author
[email protected]
Date
2012-10-17 03:08:53 -0700 (Wed, 17 Oct 2012)

Log Message

[EFL] Add background color to the checkbox theme.
https://bugs.webkit.org/show_bug.cgi?id=98788

Patch by Byungwoo Lee <[email protected]> on 2012-10-17
Reviewed by Gyuyoung Kim.

Background color is added to the checkbox theme for identifying
checkbox status easily.

Checkbox theme uses images which has transparent background, and the
theme itself doesn't have the background color.

When the background of checkbox is black, checked/unchecked status
cannot be distinguished because check mark color is black.

And it is hard to identify whether the checkbox is disabled or not,
because there is no background color in the checkbox theme.

Instead of adding background color to the edc script, background
images are added because the shape of the check box can be various.

* DefaultTheme/widget/check/check.edc:
* DefaultTheme/widget/check/img_check_bg_enabled.png: Added.
* DefaultTheme/widget/check/img_check_bg_disabled.png: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (131575 => 131576)


--- trunk/Source/WebKit/efl/ChangeLog	2012-10-17 10:08:37 UTC (rev 131575)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-10-17 10:08:53 UTC (rev 131576)
@@ -1,5 +1,31 @@
 2012-10-17  Byungwoo Lee  <[email protected]>
 
+        [EFL] Add background color to the checkbox theme.
+        https://bugs.webkit.org/show_bug.cgi?id=98788
+
+        Reviewed by Gyuyoung Kim.
+
+        Background color is added to the checkbox theme for identifying
+        checkbox status easily.
+
+        Checkbox theme uses images which has transparent background, and the
+        theme itself doesn't have the background color.
+
+        When the background of checkbox is black, checked/unchecked status
+        cannot be distinguished because check mark color is black.
+
+        And it is hard to identify whether the checkbox is disabled or not,
+        because there is no background color in the checkbox theme.
+
+        Instead of adding background color to the edc script, background
+        images are added because the shape of the check box can be various.
+
+        * DefaultTheme/widget/check/check.edc:
+        * DefaultTheme/widget/check/img_check_bg_enabled.png: Added.
+        * DefaultTheme/widget/check/img_check_bg_disabled.png: Added.
+
+2012-10-17  Byungwoo Lee  <[email protected]>
+
         [EFL] Add background color to the radio button theme.
         https://bugs.webkit.org/show_bug.cgi?id=98852

Modified: trunk/Source/WebKit/efl/DefaultTheme/widget/check/check.edc (131575 => 131576)


--- trunk/Source/WebKit/efl/DefaultTheme/widget/check/check.edc	2012-10-17 10:08:37 UTC (rev 131575)
+++ trunk/Source/WebKit/efl/DefaultTheme/widget/check/check.edc	2012-10-17 10:08:53 UTC (rev 131576)
@@ -25,6 +25,8 @@
       min: 12 12;
 
       images {
+         image: "widget/check/img_check_bg_enabled.png" COMP;
+         image: "widget/check/img_check_bg_disabled.png" COMP;
          image: "widget/check/img_check_on.png" COMP;
          image: "widget/check/img_check_off.png" COMP;
          image: "widget/check/img_check_off_focus.png" COMP;
@@ -43,6 +45,7 @@
           public show() {
               if (get_int(isEnabled) == 1) {
                   set_state(PART:"check_button", "default", 0.0);
+                  set_state(PART:"bg", "enabled", 0.0);
                   if (get_int(isChecked) == 1) {
                       set_state(PART:"check_button", "enabled_checked", 0.0);
                       if (get_int(isFocused) == 1)
@@ -59,6 +62,7 @@
               }
               else {
                   set_state(PART:"check_button", "disabled", 0.0);
+                  set_state(PART:"bg", "disabled", 0.0);
                   if (get_int(isChecked) == 1)
                       set_state(PART:"check_button", "disabled_checked", 0.0);
               }
@@ -67,6 +71,29 @@
 
       parts {
          part {
+            name: "bg";
+            type: IMAGE;
+            description {
+               state: "default" 0.0;
+               min: 12 12;
+               max: 12 12;
+               image {
+                  normal: "widget/check/img_check_bg_enabled.png";
+               }
+            }
+            description {
+               state: "enabled" 0.0;
+               inherit: "default" 0.0;
+            }
+            description {
+               state: "disabled" 0.0;
+               inherit: "default" 0.0;
+               image {
+                  normal: "widget/check/img_check_bg_disabled.png";
+               }
+            }
+         }
+         part {
             name: "check_button";
             type: IMAGE;
             description {

Added: trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png (0 => 131576)


--- trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png	                        (rev 0)
+++ trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png	2012-10-17 10:08:53 UTC (rev 131576)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDRVu\\xE7sRGB\xAE\xCE\xE9bKGD\xFF\xFF\xFF\xA0\xBD\xA7\x93	pHYs\x9A\x9CtIME\xDC
+
+\xDD\xF4PIDAT(\xCFc\x9C6m\xDA\x89`T\xC3H\xD1jِ\x90\xFC\xB8IEND\xAEB`\x82
\ No newline at end of file

Added: trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png (0 => 131576)


--- trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png	                        (rev 0)
+++ trunk/Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png	2012-10-17 10:08:53 UTC (rev 131576)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDRVu\\xE7sRGB\xAE\xCE\xE9bKGD\xFF\xFF\xFF\xA0\xBD\xA7\x93	pHYs\x9A\x9CtIME\xDC
+
+
+\xF5\xC2IDAT(\xCFc\xFC\xFF\xFF\xFF\x89`T\xC3H\xD1;=Ţ\xCCIEND\xAEB`\x82
\ No newline at end of file

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to