Title: [131591] trunk/Source/WebCore
- Revision
- 131591
- Author
- [email protected]
- Date
- 2012-10-17 05:48:53 -0700 (Wed, 17 Oct 2012)
Log Message
Web Inspector: display "disconnected" message when remote debugging terminates
https://bugs.webkit.org/show_bug.cgi?id=99316
Reviewed by Yury Semikhatsky.
Otherwise, it is not clear that the front-end is no longer functional.
* inspector/front-end/InspectorFrontendHostStub.js:
(WebInspector.RemoteDebuggingTerminatedScreen):
* inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onclose):
(WebInspector.loaded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131590 => 131591)
--- trunk/Source/WebCore/ChangeLog 2012-10-17 12:23:07 UTC (rev 131590)
+++ trunk/Source/WebCore/ChangeLog 2012-10-17 12:48:53 UTC (rev 131591)
@@ -1,3 +1,18 @@
+2012-10-17 Pavel Feldman <[email protected]>
+
+ Web Inspector: display "disconnected" message when remote debugging terminates
+ https://bugs.webkit.org/show_bug.cgi?id=99316
+
+ Reviewed by Yury Semikhatsky.
+
+ Otherwise, it is not clear that the front-end is no longer functional.
+
+ * inspector/front-end/InspectorFrontendHostStub.js:
+ (WebInspector.RemoteDebuggingTerminatedScreen):
+ * inspector/front-end/inspector.js:
+ (WebInspector.loaded.WebInspector.socket.onclose):
+ (WebInspector.loaded):
+
2012-10-17 Yury Semikhatsky <[email protected]>
Web Inspector: delete watch _expression_ button overlaps with the _expression_ value
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (131590 => 131591)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-10-17 12:23:07 UTC (rev 131590)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-10-17 12:48:53 UTC (rev 131591)
@@ -751,3 +751,5 @@
localizedStrings["Running audit"] = "Running audit";
localizedStrings["Collecting content…"] = "Collecting content…";
localizedStrings["Writing file…"] = "Writing file…";
+localizedStrings["Debug target terminated"] = "Debug target terminated";
+localizedStrings["This remote debugging client is no longer functional. Please re-attach to the new target."] = "This remote debugging client is no longer functional. Please re-attach to the new target.";
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (131590 => 131591)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2012-10-17 12:23:07 UTC (rev 131590)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2012-10-17 12:48:53 UTC (rev 131591)
@@ -222,3 +222,19 @@
}
}
+
+/**
+ * @constructor
+ * @extends {WebInspector.HelpScreen}
+ */
+WebInspector.RemoteDebuggingTerminatedScreen = function()
+{
+ WebInspector.HelpScreen.call(this, WebInspector.UIString("Debug target terminated"));
+ var p = this.contentElement.createChild("p");
+ p.addStyleClass("help-section");
+ p.textContent = WebInspector.UIString("This remote debugging client is no longer functional. Please re-attach to the new target.");
+}
+
+WebInspector.RemoteDebuggingTerminatedScreen.prototype = {
+ __proto__: WebInspector.HelpScreen.prototype
+}
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (131590 => 131591)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-10-17 12:23:07 UTC (rev 131590)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-10-17 12:48:53 UTC (rev 131591)
@@ -335,6 +335,9 @@
InspectorFrontendHost.sendMessageToBackend = WebInspector.socket.send.bind(WebInspector.socket);
WebInspector.doLoadedDone();
}
+ WebInspector.socket._onclose_ = function() {
+ (new WebInspector.RemoteDebuggingTerminatedScreen()).showModal();
+ }
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
