Title: [131596] trunk/Source/WebCore
Revision
131596
Author
[email protected]
Date
2012-10-17 08:01:03 -0700 (Wed, 17 Oct 2012)

Log Message

[Qt] Avoid re-creating CSSGrammar.cpp with each (incremental) build

Reviewed by Tor Arne Vestbø.

The expected output is CSSGrammar.cpp and the input file used to be CSSGrammar.y,
so ${QMAKE_FILE_BASE}.cpp did the correct transformation. Recently the input has
changed to CSSGrammar.y.in, in which case the ${QMAKE_FILE_BASE} is CSSGrammar.y
unfortunately. The resulting target CSSGrammar.y.cpp will never be created and
therefore the target will always run.

* DerivedSources.pri:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (131595 => 131596)


--- trunk/Source/WebCore/ChangeLog	2012-10-17 14:43:26 UTC (rev 131595)
+++ trunk/Source/WebCore/ChangeLog	2012-10-17 15:01:03 UTC (rev 131596)
@@ -1,3 +1,17 @@
+2012-10-17  Simon Hausmann  <[email protected]>
+
+        [Qt] Avoid re-creating CSSGrammar.cpp with each (incremental) build
+
+        Reviewed by Tor Arne Vestbø.
+
+        The expected output is CSSGrammar.cpp and the input file used to be CSSGrammar.y,
+        so ${QMAKE_FILE_BASE}.cpp did the correct transformation. Recently the input has
+        changed to CSSGrammar.y.in, in which case the ${QMAKE_FILE_BASE} is CSSGrammar.y
+        unfortunately. The resulting target CSSGrammar.y.cpp will never be created and
+        therefore the target will always run.
+
+        * DerivedSources.pri:
+
 2012-10-17  Ilya Tikhonovsky  <[email protected]>
 
         Unreviewed fix for ImageSourceCG.

Modified: trunk/Source/WebCore/DerivedSources.pri (131595 => 131596)


--- trunk/Source/WebCore/DerivedSources.pri	2012-10-17 14:43:26 UTC (rev 131595)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-10-17 15:01:03 UTC (rev 131596)
@@ -801,7 +801,7 @@
 GENERATORS += InjectedScriptCanvasModuleSource
 
 # GENERATOR 4: CSS grammar
-cssbison.output = ${QMAKE_FILE_BASE}.cpp
+cssbison.output = CSSGrammar.cpp
 cssbison.input = CSSBISON
 cssbison.script = $$PWD/css/makegrammar.pl
 cssbison.commands = perl -I $$PWD/bindings/scripts $$cssbison.script --outputDir ${QMAKE_FUNC_FILE_OUT_PATH} --extraDefines \"$${DEFINES} $$configDefines()\" --preprocessor \"$${QMAKE_MOC} -E\" --symbolsPrefix cssyy ${QMAKE_FILE_NAME}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to