Title: [131599] trunk/LayoutTests
- Revision
- 131599
- Author
- [email protected]
- Date
- 2012-10-17 08:30:16 -0700 (Wed, 17 Oct 2012)
Log Message
[GTK] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98366
Patch by Joanmarie Diggs <[email protected]> on 2012-10-17
Reviewed by Chris Fleizach.
The failure was due to platform-specific expectations of childrenCount.
The solution was conditionalizing the test.
* accessibility/ignore-spacer-elements.html: Base expected childrenCount on platform.
* platform/gtk/TestExpectations: Unskip previously-failing test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131598 => 131599)
--- trunk/LayoutTests/ChangeLog 2012-10-17 15:24:20 UTC (rev 131598)
+++ trunk/LayoutTests/ChangeLog 2012-10-17 15:30:16 UTC (rev 131599)
@@ -1,3 +1,16 @@
+2012-10-17 Joanmarie Diggs <[email protected]>
+
+ [GTK] accessibility/ignore-spacer-elements.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98366
+
+ Reviewed by Chris Fleizach.
+
+ The failure was due to platform-specific expectations of childrenCount.
+ The solution was conditionalizing the test.
+
+ * accessibility/ignore-spacer-elements.html: Base expected childrenCount on platform.
+ * platform/gtk/TestExpectations: Unskip previously-failing test.
+
2012-10-17 Mariusz Grzegorczyk <[email protected]>
Unreviewed EFL gardening.
Modified: trunk/LayoutTests/accessibility/ignore-spacer-elements.html (131598 => 131599)
--- trunk/LayoutTests/accessibility/ignore-spacer-elements.html 2012-10-17 15:24:20 UTC (rev 131598)
+++ trunk/LayoutTests/accessibility/ignore-spacer-elements.html 2012-10-17 15:30:16 UTC (rev 131599)
@@ -5,7 +5,7 @@
</script>
<body id="body">
- <!-- This test makes sure that spacer elements are not returned as elements. There should only be 4 elements returned -->
+ <!-- This test makes sure that spacer elements are not returned as elements. There should be at most 4 elements returned -->
<b>First</b>
<b>Second</b>
@@ -23,8 +23,10 @@
var body = document.getElementById("body");
body.focus();
var container = accessibilityController.focusedElement.childAtIndex(0);
-
- if (container.childrenCount == 4) {
+
+ // The Gtk port ATs expect the bold inline text to not have accessible objects.
+ var expectedCount = (testRunner.platformName == "gtk") ? 2 : 4;
+ if (container.childrenCount == expectedCount) {
result.innerText += "Test passed\n";
}
else {
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (131598 => 131599)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-10-17 15:24:20 UTC (rev 131598)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-10-17 15:30:16 UTC (rev 131599)
@@ -691,7 +691,6 @@
webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
webkit.org/b/98364 accessibility/editable-webarea-context-menu-point.html [ Failure ]
webkit.org/b/98365 accessibility/ellipsis-text.html [ Failure ]
-webkit.org/b/98366 accessibility/ignore-spacer-elements.html [ Failure ]
webkit.org/b/98368 accessibility/label-for-control-hittest.html [ Failure ]
webkit.org/b/98369 accessibility/language-attribute.html [ Failure ]
webkit.org/b/98370 accessibility/loading-iframe-sends-notification.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
