Title: [131612] trunk/Source/WebCore
- Revision
- 131612
- Author
- [email protected]
- Date
- 2012-10-17 09:38:59 -0700 (Wed, 17 Oct 2012)
Log Message
Web Inspector: no "delete watch _expression_" context menu item when clicking on the _expression_ value
https://bugs.webkit.org/show_bug.cgi?id=99602
Reviewed by Pavel Feldman.
Add delete items to the watch _expression_'s value's context menu.
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
(WebInspector.ObjectPropertyTreeElement.prototype.populateContextMenu):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype._contextMenu):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131611 => 131612)
--- trunk/Source/WebCore/ChangeLog 2012-10-17 16:32:29 UTC (rev 131611)
+++ trunk/Source/WebCore/ChangeLog 2012-10-17 16:38:59 UTC (rev 131612)
@@ -1,3 +1,19 @@
+2012-10-17 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: no "delete watch _expression_" context menu item when clicking on the _expression_ value
+ https://bugs.webkit.org/show_bug.cgi?id=99602
+
+ Reviewed by Pavel Feldman.
+
+ Add delete items to the watch _expression_'s value's context menu.
+
+ * inspector/front-end/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuFired):
+ (WebInspector.ObjectPropertyTreeElement.prototype.populateContextMenu):
+ * inspector/front-end/WatchExpressionsSidebarPane.js:
+ (WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):
+ (WebInspector.WatchExpressionTreeElement.prototype._contextMenu):
+
2012-10-17 Vsevolod Vlasov <[email protected]>
Web Inspector: [Regression] Undoing script changes does not restore breakpoints.
Modified: trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (131611 => 131612)
--- trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-10-17 16:32:29 UTC (rev 131611)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-10-17 16:38:59 UTC (rev 131612)
@@ -254,10 +254,18 @@
_contextMenuFired: function(value, event)
{
var contextMenu = new WebInspector.ContextMenu();
+ this.populateContextMenu(contextMenu);
contextMenu.appendApplicableItems(value);
contextMenu.show(event);
},
+ /**
+ * @param {WebInspector.ContextMenu} contextMenu
+ */
+ populateContextMenu: function(contextMenu)
+ {
+ },
+
updateSiblings: function()
{
if (this.parent.root)
Modified: trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js (131611 => 131612)
--- trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js 2012-10-17 16:32:29 UTC (rev 131611)
+++ trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js 2012-10-17 16:38:59 UTC (rev 131612)
@@ -391,12 +391,21 @@
this.listItemElement.insertBefore(deleteButton, this.listItemElement.firstChild);
},
- _contextMenu: function(event)
+ /**
+ * @param {WebInspector.ContextMenu} contextMenu
+ * @override
+ */
+ populateContextMenu: function(contextMenu)
{
- var contextMenu = new WebInspector.ContextMenu();
contextMenu.appendItem(WebInspector.UIString("Delete watch _expression_"), this._deleteButtonClicked.bind(this));
if (this.treeOutline.section.watchExpressions.length > 1)
contextMenu.appendItem(WebInspector.UIString("Delete all watch expressions"), this._deleteAllButtonClicked.bind(this));
+ },
+
+ _contextMenu: function(event)
+ {
+ var contextMenu = new WebInspector.ContextMenu();
+ this.populateContextMenu(contextMenu);
contextMenu.show(event);
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
