Title: [131623] trunk/Source/WTF
- Revision
- 131623
- Author
- [email protected]
- Date
- 2012-10-17 11:00:11 -0700 (Wed, 17 Oct 2012)
Log Message
Always use fastRealloc when growing or shrinking the Vector buffer
https://bugs.webkit.org/show_bug.cgi?id=99616
Reviewed by Andreas Kling.
Remove the pointless #if PLATFORM(BLACKBERRY) and always try to use fastRealloc to grow or shrink the
vector buffer when possible; realloc should always be at least as fast as free+malloc.
* wtf/Vector.h:
(WTF::VectorBufferBase::shouldReallocateBuffer):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (131622 => 131623)
--- trunk/Source/WTF/ChangeLog 2012-10-17 17:55:30 UTC (rev 131622)
+++ trunk/Source/WTF/ChangeLog 2012-10-17 18:00:11 UTC (rev 131623)
@@ -1,3 +1,16 @@
+2012-10-17 Anders Carlsson <[email protected]>
+
+ Always use fastRealloc when growing or shrinking the Vector buffer
+ https://bugs.webkit.org/show_bug.cgi?id=99616
+
+ Reviewed by Andreas Kling.
+
+ Remove the pointless #if PLATFORM(BLACKBERRY) and always try to use fastRealloc to grow or shrink the
+ vector buffer when possible; realloc should always be at least as fast as free+malloc.
+
+ * wtf/Vector.h:
+ (WTF::VectorBufferBase::shouldReallocateBuffer):
+
2012-10-16 Michael Saboff <[email protected]>
Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN
Modified: trunk/Source/WTF/wtf/Vector.h (131622 => 131623)
--- trunk/Source/WTF/wtf/Vector.h 2012-10-17 17:55:30 UTC (rev 131622)
+++ trunk/Source/WTF/wtf/Vector.h 2012-10-17 18:00:11 UTC (rev 131623)
@@ -278,14 +278,7 @@
bool shouldReallocateBuffer(size_t newCapacity) const
{
-#if PLATFORM(BLACKBERRY)
- // Tested on BlackBerry.
return VectorTraits<T>::canMoveWithMemcpy && m_capacity && newCapacity;
-#else
- // FIXME: Return true on the platforms where realloc() gives better performance.
- UNUSED_PARAM(newCapacity);
- return false;
-#endif
}
void reallocateBuffer(size_t newCapacity)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
