Title: [131646] trunk/Source/_javascript_Core
- Revision
- 131646
- Author
- [email protected]
- Date
- 2012-10-17 14:48:03 -0700 (Wed, 17 Oct 2012)
Log Message
Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
https://bugs.webkit.org/show_bug.cgi?id=99557
Reviewed by Geoffrey Garen.
Removed an inaccurate and misleading comment as per Geoff's review. (I forgot
to make this change as part of http://trac.webkit.org/changeset/131644).
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (131645 => 131646)
--- trunk/Source/_javascript_Core/ChangeLog 2012-10-17 21:42:43 UTC (rev 131645)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-10-17 21:48:03 UTC (rev 131646)
@@ -1,3 +1,16 @@
+2012-10-17 Filip Pizlo <[email protected]>
+
+ Array and object allocations via 'new Object' or 'new Array' should be inlined in bytecode to allow allocation site profiling
+ https://bugs.webkit.org/show_bug.cgi?id=99557
+
+ Reviewed by Geoffrey Garen.
+
+ Removed an inaccurate and misleading comment as per Geoff's review. (I forgot
+ to make this change as part of http://trac.webkit.org/changeset/131644).
+
+ * bytecompiler/NodesCodegen.cpp:
+ (JSC::FunctionCallResolveNode::emitBytecode):
+
2012-10-17 Oliver Hunt <[email protected]>
Bytecode should not have responsibility for determining how to perform non-local resolves
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (131645 => 131646)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2012-10-17 21:42:43 UTC (rev 131645)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2012-10-17 21:48:03 UTC (rev 131646)
@@ -445,7 +445,6 @@
generator.emitExpressionInfo(identifierStart + m_ident.length(), m_ident.length(), 0);
generator.emitResolveWithThis(callArguments.thisRegister(), func.get(), resolveResult, m_ident);
- // FIXME: Reconsider passing expectedFunction instead of NoExpectedFunction.
return generator.emitCall(generator.finalDestinationOrIgnored(dst, func.get()), func.get(), expectedFunction, callArguments, divot(), startOffset(), endOffset());
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
