Diff
Modified: trunk/Tools/ChangeLog (131698 => 131699)
--- trunk/Tools/ChangeLog 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/ChangeLog 2012-10-18 02:24:42 UTC (rev 131699)
@@ -1,3 +1,33 @@
+2012-10-17 Dirk Pranke <[email protected]>
+
+ [chromium] stop falling back to platform/mac for LayoutTest results
+ https://bugs.webkit.org/show_bug.cgi?id=99666
+
+ Reviewed by James Robinson.
+
+ Previously the Chromium ports would fall back to results in
+ platform/mac if a result was not found in platform/chromium-*.
+ This allowed us to share a lot of results w/ the Apple Mac port,
+ but often surprised people (especially at Apple ;) when changing
+ something in that directory would break a Chromium build.
+
+ The tests that are deleted in baselineoptimizer were for cases
+ that are no longer relevant or possible in the current fallback
+ graph.
+
+ * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
+ (BaselineOptimizerTest.test_move_baselines):
+ (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
+ * Scripts/webkitpy/layout_tests/port/chromium_android.py:
+ (ChromiumAndroidPort):
+ * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+ (ChromiumLinuxPort):
+ * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+ (ChromiumMacPort):
+ * Scripts/webkitpy/layout_tests/port/chromium_win.py:
+ (ChromiumWinPort):
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+
2012-10-17 Shashi Shekhar <[email protected]>
Remove redundant sdk_build parameter.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py (131698 => 131699)
--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2012-10-18 02:24:42 UTC (rev 131699)
@@ -74,20 +74,6 @@
})
self.assertEqual(host.filesystem.read_binary_file('/mock-checkout/LayoutTests/platform/chromium/another/test-expected.txt'), 'result A')
- def test_platform_mac_different(self):
- self._assertOptimization({
- 'LayoutTests': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/mac': '453e67177a75b2e79905154ece0efba6e5bfb65d',
- 'LayoutTests/platform/mac-lion': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/chromium-mac': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- }, {
- 'LayoutTests': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/mac': '453e67177a75b2e79905154ece0efba6e5bfb65d',
- 'LayoutTests/platform/mac-lion': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/chromium': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- })
-
def test_chromium_linux_redundant_with_win(self):
self._assertOptimization({
'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
@@ -118,14 +104,6 @@
'LayoutTests/platform/chromium': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
})
- def test_chromium_mac_redundant_with_apple_mac(self):
- self._assertOptimization({
- 'LayoutTests/platform/chromium-mac': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- 'LayoutTests/platform/mac': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- }, {
- 'LayoutTests/platform/mac': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
- })
-
def test_mac_future(self):
self._assertOptimization({
'LayoutTests/platform/mac-lion': '462d03b9c025db1b0392d7453310dbee5f9a9e74',
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (131698 => 131699)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-10-18 02:24:42 UTC (rev 131699)
@@ -157,7 +157,6 @@
'chromium-linux',
'chromium-win',
'chromium',
- 'mac',
]
def __init__(self, host, port_name, **kwargs):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py (131698 => 131699)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py 2012-10-18 02:24:42 UTC (rev 131699)
@@ -46,14 +46,12 @@
'chromium-linux',
'chromium-win',
'chromium',
- 'mac',
],
'x86': [
'chromium-linux-x86',
'chromium-linux',
'chromium-win',
'chromium',
- 'mac',
],
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py (131698 => 131699)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py 2012-10-18 02:24:42 UTC (rev 131699)
@@ -47,22 +47,18 @@
'chromium-mac-snowleopard',
'chromium-mac',
'chromium',
- 'mac',
],
'lion': [
'chromium-mac',
'chromium',
- 'mac',
],
'mountainlion': [ # FIXME: we don't treat ML different from Lion yet.
'chromium-mac',
'chromium',
- 'mac',
],
'future': [
'chromium-mac',
'chromium',
- 'mac',
],
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (131698 => 131699)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2012-10-18 02:24:42 UTC (rev 131699)
@@ -44,18 +44,15 @@
# FIXME: Figure out how to unify this with base.TestConfiguration.all_systems()?
SUPPORTED_VERSIONS = ('xp', 'win7')
- # FIXME: Do we need mac-snowleopard here, like the base win port?
FALLBACK_PATHS = {
'xp': [
'chromium-win-xp',
'chromium-win',
'chromium',
- 'mac',
],
'win7': [
'chromium-win',
'chromium',
- 'mac',
],
}
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (131698 => 131699)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-10-18 02:11:49 UTC (rev 131698)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-10-18 02:24:42 UTC (rev 131699)
@@ -2522,12 +2522,12 @@
}
var g_fallbacksMap = {};
-g_fallbacksMap['WIN-XP'] = ['chromium-win-xp', 'chromium-win', 'chromium', 'mac'];
-g_fallbacksMap['WIN-7'] = ['chromium-win', 'chromium', 'mac'];
-g_fallbacksMap['MAC-SNOWLEOPARD'] = ['chromium-mac-snowleopard', 'chromium-mac', 'chromium', 'mac'];
-g_fallbacksMap['MAC-LION'] = ['chromium-mac', 'chromium', 'mac'];
-g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium', 'mac'];
-g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium', 'mac'];
+g_fallbacksMap['WIN-XP'] = ['chromium-win-xp', 'chromium-win', 'chromium'];
+g_fallbacksMap['WIN-7'] = ['chromium-win', 'chromium'];
+g_fallbacksMap['MAC-SNOWLEOPARD'] = ['chromium-mac-snowleopard', 'chromium-mac', 'chromium'];
+g_fallbacksMap['MAC-LION'] = ['chromium-mac', 'chromium'];
+g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium'];
+g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium'];
function htmlForFallbackHelp(fallbacks)
{
