Title: [131707] trunk
- Revision
- 131707
- Author
- [email protected]
- Date
- 2012-10-17 22:59:58 -0700 (Wed, 17 Oct 2012)
Log Message
Remove the JSHeap memory measurement of the PageLoad performacetests since it creates bogus JSGlobalDatas
https://bugs.webkit.org/show_bug.cgi?id=99609
Reviewed by Ryosuke Niwa.
Remove the implementation since it creates bogus JSGlobalDatas in the layout tests.
Source/_javascript_Core:
* heap/HeapStatistics.cpp:
(JSC):
* heap/HeapStatistics.h:
(HeapStatistics):
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (131706 => 131707)
--- trunk/Source/_javascript_Core/ChangeLog 2012-10-18 05:55:11 UTC (rev 131706)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-10-18 05:59:58 UTC (rev 131707)
@@ -1,3 +1,17 @@
+2012-10-17 Zoltan Horvath <[email protected]>
+
+ Remove the JSHeap memory measurement of the PageLoad performacetests since it creates bogus JSGlobalDatas
+ https://bugs.webkit.org/show_bug.cgi?id=99609
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove the implementation since it creates bogus JSGlobalDatas in the layout tests.
+
+ * heap/HeapStatistics.cpp:
+ (JSC):
+ * heap/HeapStatistics.h:
+ (HeapStatistics):
+
2012-10-17 Sam Weinig <[email protected]>
Attempt to fix the build.
Modified: trunk/Source/_javascript_Core/heap/HeapStatistics.cpp (131706 => 131707)
--- trunk/Source/_javascript_Core/heap/HeapStatistics.cpp 2012-10-18 05:55:11 UTC (rev 131706)
+++ trunk/Source/_javascript_Core/heap/HeapStatistics.cpp 2012-10-18 05:59:58 UTC (rev 131707)
@@ -138,12 +138,6 @@
#endif // OS(UNIX)
-size_t HeapStatistics::usedJSHeap()
-{
- JSGlobalData* globalData = &JSGlobalData::sharedInstance();
- return globalData->heap.size();
-}
-
size_t HeapStatistics::parseMemoryAmount(char* s)
{
size_t multiplier = 1;
Modified: trunk/Source/_javascript_Core/heap/HeapStatistics.h (131706 => 131707)
--- trunk/Source/_javascript_Core/heap/HeapStatistics.h 2012-10-18 05:55:11 UTC (rev 131706)
+++ trunk/Source/_javascript_Core/heap/HeapStatistics.h 2012-10-18 05:59:58 UTC (rev 131707)
@@ -36,7 +36,6 @@
public:
NO_RETURN static void exitWithFailure();
JS_EXPORT_PRIVATE static void reportSuccess();
- JS_EXPORT_PRIVATE static size_t usedJSHeap();
static void initialize();
static void recordGCPauseTime(double start, double end);
Modified: trunk/Tools/ChangeLog (131706 => 131707)
--- trunk/Tools/ChangeLog 2012-10-18 05:55:11 UTC (rev 131706)
+++ trunk/Tools/ChangeLog 2012-10-18 05:59:58 UTC (rev 131707)
@@ -1,3 +1,15 @@
+2012-10-17 Zoltan Horvath <[email protected]>
+
+ Remove the JSHeap memory measurement of the PageLoad performacetests since it creates bogus JSGlobalDatas
+ https://bugs.webkit.org/show_bug.cgi?id=99609
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove the implementation since it creates bogus JSGlobalDatas in the layout tests.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (dump):
+
2012-10-17 Dirk Pranke <[email protected]>
[chromium] stop falling back to platform/mac for LayoutTest results
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (131706 => 131707)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-10-18 05:55:11 UTC (rev 131706)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-10-18 05:59:58 UTC (rev 131707)
@@ -1186,7 +1186,6 @@
WTF::FastMallocStatistics mallocStats = WTF::fastMallocStatistics();
printf("DumpMalloc: %li\n", mallocStats.committedVMBytes);
- printf("DumpJSHeap: %li\n", JSC::HeapStatistics::usedJSHeap());
if (resultData) {
fwrite([resultData bytes], 1, [resultData length], stdout);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
