Title: [131724] trunk/Source/WebKit2
- Revision
- 131724
- Author
- [email protected]
- Date
- 2012-10-18 03:41:25 -0700 (Thu, 18 Oct 2012)
Log Message
[CMake] Depend on the Python scripts in WebKit2/Scripts/webkit2 when regenerating messages.
https://bugs.webkit.org/show_bug.cgi?id=99702
Reviewed by Gyuyoung Kim.
Be in line with most (or all) the other build systems and
explicitly depend on all the scripts in
${WEBKIT2_DIR}/Scripts/webkit2 for the custom command that
generates messages.
This helps fix the build after the recent change to messages.py,
which did not trigger a regeneration of the required files --
people were just removing their DerivedSources directory
altogether.
* CMakeLists.txt:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (131723 => 131724)
--- trunk/Source/WebKit2/CMakeLists.txt 2012-10-18 10:38:18 UTC (rev 131723)
+++ trunk/Source/WebKit2/CMakeLists.txt 2012-10-18 10:41:25 UTC (rev 131724)
@@ -589,6 +589,10 @@
ADD_CUSTOM_COMMAND(
OUTPUT ${DERIVED_SOURCES_WEBKIT2_DIR}/${_name}MessageReceiver.cpp ${DERIVED_SOURCES_WEBKIT2_DIR}/${_name}Messages.h
MAIN_DEPENDENCY ${_file}
+ DEPENDS ${WEBKIT2_DIR}/Scripts/webkit2/__init__.py
+ ${WEBKIT2_DIR}/Scripts/webkit2/messages.py
+ ${WEBKIT2_DIR}/Scripts/webkit2/model.py
+ ${WEBKIT2_DIR}/Scripts/webkit2/parser.py
COMMAND ${PYTHON_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-message-receiver.py ${_file} > ${DERIVED_SOURCES_WEBKIT2_DIR}/${_name}MessageReceiver.cpp
COMMAND ${PYTHON_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-messages-header.py ${_file} > ${DERIVED_SOURCES_WEBKIT2_DIR}/${_name}Messages.h
WORKING_DIRECTORY ${WEBKIT2_DIR}
Modified: trunk/Source/WebKit2/ChangeLog (131723 => 131724)
--- trunk/Source/WebKit2/ChangeLog 2012-10-18 10:38:18 UTC (rev 131723)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-18 10:41:25 UTC (rev 131724)
@@ -1,3 +1,22 @@
+2012-10-18 Raphael Kubo da Costa <[email protected]>
+
+ [CMake] Depend on the Python scripts in WebKit2/Scripts/webkit2 when regenerating messages.
+ https://bugs.webkit.org/show_bug.cgi?id=99702
+
+ Reviewed by Gyuyoung Kim.
+
+ Be in line with most (or all) the other build systems and
+ explicitly depend on all the scripts in
+ ${WEBKIT2_DIR}/Scripts/webkit2 for the custom command that
+ generates messages.
+
+ This helps fix the build after the recent change to messages.py,
+ which did not trigger a regeneration of the required files --
+ people were just removing their DerivedSources directory
+ altogether.
+
+ * CMakeLists.txt:
+
2012-10-18 Byungwoo Lee <[email protected]>
[WK2] Fix incorrect test expectations of messages_unittest.py.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
