Title: [131736] trunk/Source/WebCore
- Revision
- 131736
- Author
- apav...@chromium.org
- Date
- 2012-10-18 06:18:44 -0700 (Thu, 18 Oct 2012)
Log Message
Web Inspector: [Styles] Forcibly invoke property names suggestion box for empty prefix
https://bugs.webkit.org/show_bug.cgi?id=99711
Reviewed by Vsevolod Vlasov.
Suggestions should be returned unconditionally for CSS property names, regardless of the prefix.
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131735 => 131736)
--- trunk/Source/WebCore/ChangeLog 2012-10-18 12:48:42 UTC (rev 131735)
+++ trunk/Source/WebCore/ChangeLog 2012-10-18 13:18:44 UTC (rev 131736)
@@ -1,3 +1,19 @@
+2012-10-18 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: [Styles] Forcibly invoke property names suggestion box for empty prefix
+ https://bugs.webkit.org/show_bug.cgi?id=99711
+
+ Reviewed by Vsevolod Vlasov.
+
+ Suggestions should be returned unconditionally for CSS property names, regardless of the prefix.
+
+ * inspector/front-end/CSSCompletions.js:
+ (WebInspector.CSSCompletions):
+ (WebInspector.CSSCompletions.requestCSSNameCompletions):
+ (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
+ * inspector/front-end/CSSKeywordCompletions.js:
+ (WebInspector.CSSKeywordCompletions.forProperty):
+
2012-10-18 Raphael Kubo da Costa <raphael.kubo.da.co...@intel.com>
Unreviewed, do not make UseV8.cmake executable.
Modified: trunk/Source/WebCore/inspector/front-end/CSSCompletions.js (131735 => 131736)
--- trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2012-10-18 12:48:42 UTC (rev 131735)
+++ trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2012-10-18 13:18:44 UTC (rev 131736)
@@ -34,7 +34,7 @@
* @constructor
* @param {Array.<CSSAgent.CSSPropertyInfo|string>} properties
*/
-WebInspector.CSSCompletions = function(properties, acceptEmptyPrefix)
+WebInspector.CSSCompletions = function(properties)
{
this._values = [];
this._longhands = {};
@@ -64,7 +64,6 @@
}
}
this._values.sort();
- this._acceptEmptyPrefix = acceptEmptyPrefix;
}
@@ -78,7 +77,7 @@
function propertyNamesCallback(error, properties)
{
if (!error)
- WebInspector.CSSCompletions.cssPropertiesMetainfo = new WebInspector.CSSCompletions(properties, false);
+ WebInspector.CSSCompletions.cssPropertiesMetainfo = new WebInspector.CSSCompletions(properties);
}
CSSAgent.getSupportedCSSProperties(propertyNamesCallback);
}
@@ -246,7 +245,7 @@
if (!this._values.length)
return -1;
if (!prefix)
- return this._acceptEmptyPrefix ? 0 : -1;
+ return 0;
var maxIndex = this._values.length - 1;
var minIndex = 0;
Modified: trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js (131735 => 131736)
--- trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2012-10-18 12:48:42 UTC (rev 131735)
+++ trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2012-10-18 13:18:44 UTC (rev 131736)
@@ -39,7 +39,7 @@
acceptedKeywords = acceptedKeywords.concat(WebInspector.CSSKeywordCompletions._colors);
if (propertyName in WebInspector.CSSKeywordCompletions.InheritedProperties)
acceptedKeywords.push("inherit");
- return new WebInspector.CSSCompletions(acceptedKeywords, true);
+ return new WebInspector.CSSCompletions(acceptedKeywords);
}
WebInspector.CSSKeywordCompletions.isColorAwareProperty = function(propertyName)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
