Title: [131759] trunk/Source/WebKit/blackberry
- Revision
- 131759
- Author
- [email protected]
- Date
- 2012-10-18 09:04:33 -0700 (Thu, 18 Oct 2012)
Log Message
[BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
https://bugs.webkit.org/show_bug.cgi?id=99624
Reviewed by Rob Buis.
Patch by Jacky Jiang <[email protected]>
Internally reviewed by Arvid Nilsson
PR: 225981
Several reasons to eliminate the ancient unnecessary
zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:
- At this point, we have only committed the data we received.
- For the new load, we haven't started parsing the tokens and building
the DOM tree and the first layout will happen after that.
- For the load restored from cache, the first layout will happen after
setLoadState committed which is called by
FrameLoader::dispatchDidCommitLoad().
- zoomToInitialScaleOnLoad() can still be called after the first
layout finished.
- zoomToInitialScaleOnLoad() is expensive and it will boost the load
performance after the removal.
- Removal of this can fix some weird rendering defects on yahoo.com,
maps.google.com, news.qq.com and so on during load and rotation
mentioned on the PR.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (131758 => 131759)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-18 16:00:26 UTC (rev 131758)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-18 16:04:33 UTC (rev 131759)
@@ -1160,8 +1160,6 @@
if (m_backingStore->d->renderVisibleContents() && !m_backingStore->d->isSuspended() && !m_backingStore->d->shouldDirectRenderingToWindow())
m_backingStore->d->blitVisibleContents();
- zoomToInitialScaleOnLoad();
-
// Update cursor status.
updateCursor();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (131758 => 131759)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-10-18 16:00:26 UTC (rev 131758)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-10-18 16:04:33 UTC (rev 131759)
@@ -1,3 +1,31 @@
+2012-10-17 Jacky Jiang <[email protected]>
+
+ [BlackBerry] Possible redundant zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState
+ https://bugs.webkit.org/show_bug.cgi?id=99624
+
+ Reviewed by Rob Buis.
+ Internally reviewed by Arvid Nilsson
+
+ PR: 225981
+ Several reasons to eliminate the ancient unnecessary
+ zoomToInitialScaleOnLoad() in WebPagePrivate::setLoadState committed:
+ - At this point, we have only committed the data we received.
+ - For the new load, we haven't started parsing the tokens and building
+ the DOM tree and the first layout will happen after that.
+ - For the load restored from cache, the first layout will happen after
+ setLoadState committed which is called by
+ FrameLoader::dispatchDidCommitLoad().
+ - zoomToInitialScaleOnLoad() can still be called after the first
+ layout finished.
+ - zoomToInitialScaleOnLoad() is expensive and it will boost the load
+ performance after the removal.
+ - Removal of this can fix some weird rendering defects on yahoo.com,
+ maps.google.com, news.qq.com and so on during load and rotation
+ mentioned on the PR.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::setLoadState):
+
2012-10-17 Mike Fenton <[email protected]>
[BlackBerry] Prevent focus zoom on non-userscalable pages.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
