Title: [131785] trunk/Source/WebCore
Revision
131785
Author
[email protected]
Date
2012-10-18 12:03:28 -0700 (Thu, 18 Oct 2012)

Log Message

Crash in WebCore::Document::webkitExitFullscreen + 618
https://bugs.webkit.org/show_bug.cgi?id=99496

Reviewed by Eric Carlson.

Prospective fix for null-dereference crash in Document::webkitExitFullscreen().

* dom/Document.cpp:
(WebCore::Document::webkitExitFullscreen): Null check page() before calling page()->chrome.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (131784 => 131785)


--- trunk/Source/WebCore/ChangeLog	2012-10-18 18:53:00 UTC (rev 131784)
+++ trunk/Source/WebCore/ChangeLog	2012-10-18 19:03:28 UTC (rev 131785)
@@ -1,3 +1,15 @@
+2012-10-18  Jer Noble  <[email protected]>
+
+        Crash in WebCore::Document::webkitExitFullscreen + 618
+        https://bugs.webkit.org/show_bug.cgi?id=99496
+
+        Reviewed by Eric Carlson.
+
+        Prospective fix for null-dereference crash in Document::webkitExitFullscreen().
+
+        * dom/Document.cpp:
+        (WebCore::Document::webkitExitFullscreen): Null check page() before calling page()->chrome.
+
 2012-10-18  Pablo Flouret  <[email protected]>
 
         Implement css3-conditional's @supports rule

Modified: trunk/Source/WebCore/dom/Document.cpp (131784 => 131785)


--- trunk/Source/WebCore/dom/Document.cpp	2012-10-18 18:53:00 UTC (rev 131784)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-10-18 19:03:28 UTC (rev 131785)
@@ -5241,6 +5241,9 @@
     // 6. Return, and run the remaining steps asynchronously.
     // 7. Optionally, perform some animation.
 
+    if (!page())
+        return;
+
     // Only exit out of full screen window mode if there are no remaining elements in the 
     // full screen stack.
     if (!newTop) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to