Title: [131849] trunk
- Revision
- 131849
- Author
- [email protected]
- Date
- 2012-10-18 20:49:46 -0700 (Thu, 18 Oct 2012)
Log Message
Fix build warning.
https://bugs.webkit.org/show_bug.cgi?id=99788
Patch by Byungwoo Lee <[email protected]> on 2012-10-18
Reviewed by Kentaro Hara.
Source/WebCore:
Use UNUSED_PARAM macro for removing -Wunused-parameter.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform):
Source/WebKit2:
Remove parameter name or use ASSERT_UNUSED macro for removing
-Wunused-parameter.
* PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
Tools:
Use return value of mktemp() for removing -Wunused-result.
* MiniBrowser/efl/main.c:
(on_download_request):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131848 => 131849)
--- trunk/Source/WebCore/ChangeLog 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Source/WebCore/ChangeLog 2012-10-19 03:49:46 UTC (rev 131849)
@@ -1,3 +1,15 @@
+2012-10-18 Byungwoo Lee <[email protected]>
+
+ Fix build warning.
+ https://bugs.webkit.org/show_bug.cgi?id=99788
+
+ Reviewed by Kentaro Hara.
+
+ Use UNUSED_PARAM macro for removing -Wunused-parameter.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::currentTransform):
+
2012-10-18 Benjamin Poulain <[email protected]>
[WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (131848 => 131849)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-10-19 03:49:46 UTC (rev 131849)
@@ -619,6 +619,8 @@
makeMatrixRenderable(currTransform, canRender3DTransforms());
return currTransform;
}
+#else
+ UNUSED_PARAM(applyOrigin);
#endif
return *m_transform;
Modified: trunk/Source/WebKit2/ChangeLog (131848 => 131849)
--- trunk/Source/WebKit2/ChangeLog 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-19 03:49:46 UTC (rev 131849)
@@ -1,3 +1,18 @@
+2012-10-18 Byungwoo Lee <[email protected]>
+
+ Fix build warning.
+ https://bugs.webkit.org/show_bug.cgi?id=99788
+
+ Reviewed by Kentaro Hara.
+
+ Remove parameter name or use ASSERT_UNUSED macro for removing
+ -Wunused-parameter.
+
+ * PluginProcess/unix/PluginProcessMainUnix.cpp:
+ (WebKit::PluginProcessMainUnix):
+ * UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
+ (WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
+
2012-10-18 Ryuan Choi <[email protected]>
Attempt to fix the WebKit2/Efl build after r131841.
Modified: trunk/Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp (131848 => 131849)
--- trunk/Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp 2012-10-19 03:49:46 UTC (rev 131849)
@@ -73,9 +73,9 @@
WK_EXPORT int PluginProcessMainUnix(int argc, char* argv[])
{
- ASSERT(argc == 2 || argc == 3);
+ ASSERT_UNUSED(argc, argc == 2 || argc == 3);
bool scanPlugin = !strcmp(argv[1], "-scanPlugin");
- ASSERT(argc == 2 || (argc == 3 && scanPlugin));
+ ASSERT_UNUSED(argc, argc == 2 || (argc == 3 && scanPlugin));
#if PLATFORM(GTK)
gtk_init(&argc, &argv);
Modified: trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp (131848 => 131849)
--- trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp 2012-10-19 03:49:46 UTC (rev 131849)
@@ -43,7 +43,7 @@
namespace WebKit {
-void PluginProcessProxy::platformInitializeLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions, const PluginModuleInfo& pluginInfo)
+void PluginProcessProxy::platformInitializeLaunchOptions(ProcessLauncher::LaunchOptions&, const PluginModuleInfo&)
{
}
Modified: trunk/Tools/ChangeLog (131848 => 131849)
--- trunk/Tools/ChangeLog 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Tools/ChangeLog 2012-10-19 03:49:46 UTC (rev 131849)
@@ -1,3 +1,15 @@
+2012-10-18 Byungwoo Lee <[email protected]>
+
+ Fix build warning.
+ https://bugs.webkit.org/show_bug.cgi?id=99788
+
+ Reviewed by Kentaro Hara.
+
+ Use return value of mktemp() for removing -Wunused-result.
+
+ * MiniBrowser/efl/main.c:
+ (on_download_request):
+
2012-10-18 Benjamin Poulain <[email protected]>
[WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
Modified: trunk/Tools/MiniBrowser/efl/main.c (131848 => 131849)
--- trunk/Tools/MiniBrowser/efl/main.c 2012-10-19 03:12:20 UTC (rev 131848)
+++ trunk/Tools/MiniBrowser/efl/main.c 2012-10-19 03:49:46 UTC (rev 131849)
@@ -300,8 +300,7 @@
else {
// Generate a unique file name since no name was suggested.
char unique_path[] = "/tmp/downloaded-file.XXXXXX";
- mktemp(unique_path);
- eina_strbuf_append(destination_path, unique_path);
+ eina_strbuf_append(destination_path, mktemp(unique_path));
}
ewk_download_job_destination_set(download, eina_strbuf_string_get(destination_path));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
