Title: [131857] trunk/Source/WebCore
Revision
131857
Author
[email protected]
Date
2012-10-18 22:36:04 -0700 (Thu, 18 Oct 2012)

Log Message

Automatically start plugins created within a user gesture, skipping snapshotting
https://bugs.webkit.org/show_bug.cgi?id=99778

Patch by Kiran Muppala <[email protected]> on 2012-10-18
Reviewed by Alexey Proskuryakov.

If a user gesture is being processed, do not set the display state of
HTMLPluginImageElement to WaitingForSnapshot.

No new tests, since it only affects when plugins switch from snapshot to running
state.  Does not affect rendering of other elements.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (131856 => 131857)


--- trunk/Source/WebCore/ChangeLog	2012-10-19 05:32:18 UTC (rev 131856)
+++ trunk/Source/WebCore/ChangeLog	2012-10-19 05:36:04 UTC (rev 131857)
@@ -1,3 +1,19 @@
+2012-10-18  Kiran Muppala  <[email protected]>
+
+        Automatically start plugins created within a user gesture, skipping snapshotting
+        https://bugs.webkit.org/show_bug.cgi?id=99778
+
+        Reviewed by Alexey Proskuryakov.
+
+        If a user gesture is being processed, do not set the display state of
+        HTMLPluginImageElement to WaitingForSnapshot.
+
+        No new tests, since it only affects when plugins switch from snapshot to running
+        state.  Does not affect rendering of other elements.
+
+        * html/HTMLPlugInImageElement.cpp:
+        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
+
 2012-10-18  Kent Tamura  <[email protected]>
 
         Add shortMonthLabels and shortStandAloneMonthLabels to Localizer

Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (131856 => 131857)


--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp	2012-10-19 05:32:18 UTC (rev 131856)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp	2012-10-19 05:36:04 UTC (rev 131857)
@@ -50,7 +50,9 @@
 {
     setHasCustomCallbacks();
 
-    if (document->page() && document->page()->settings()->plugInSnapshottingEnabled())
+    if (document->page()
+        && document->page()->settings()->plugInSnapshottingEnabled()
+        && !ScriptController::processingUserGesture())
         setDisplayState(WaitingForSnapshot);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to