Title: [131866] trunk/Source/WebCore
- Revision
- 131866
- Author
- [email protected]
- Date
- 2012-10-19 00:07:58 -0700 (Fri, 19 Oct 2012)
Log Message
[V8] DOMObjectVisitor does nothing
https://bugs.webkit.org/show_bug.cgi?id=99812
Reviewed by Kentaro Hara.
This code doesn't do anything, even in Debug! We should just remove it.
* bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131865 => 131866)
--- trunk/Source/WebCore/ChangeLog 2012-10-19 07:05:07 UTC (rev 131865)
+++ trunk/Source/WebCore/ChangeLog 2012-10-19 07:07:58 UTC (rev 131866)
@@ -1,5 +1,19 @@
2012-10-19 Adam Barth <[email protected]>
+ [V8] DOMObjectVisitor does nothing
+ https://bugs.webkit.org/show_bug.cgi?id=99812
+
+ Reviewed by Kentaro Hara.
+
+ This code doesn't do anything, even in Debug! We should just remove it.
+
+ * bindings/v8/V8GCController.cpp:
+ (WebCore):
+ (WebCore::V8GCController::gcPrologue):
+ (WebCore::V8GCController::gcEpilogue):
+
+2012-10-19 Adam Barth <[email protected]>
+
[V8] Remove unused typedef from V8GCController.cpp
https://bugs.webkit.org/show_bug.cgi?id=99808
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (131865 => 131866)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-10-19 07:05:07 UTC (rev 131865)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2012-10-19 07:07:58 UTC (rev 131866)
@@ -68,16 +68,6 @@
#ifndef NDEBUG
-class DOMObjectVisitor : public DOMWrapperMap<void>::Visitor {
-public:
- void visitDOMWrapper(DOMDataStore* store, void* object, v8::Persistent<v8::Object> wrapper)
- {
- WrapperTypeInfo* type = V8DOMWrapper::domWrapperType(wrapper);
- UNUSED_PARAM(type);
- UNUSED_PARAM(object);
- }
-};
-
class EnsureWeakDOMNodeVisitor : public DOMWrapperMap<Node>::Visitor {
public:
void visitDOMWrapper(DOMDataStore* store, Node* object, v8::Persistent<v8::Object> wrapper)
@@ -335,14 +325,9 @@
// Create object groups for DOM tree nodes.
void V8GCController::gcPrologue()
{
- v8::HandleScope scope;
-
TRACE_EVENT_BEGIN0("v8", "GC");
-#ifndef NDEBUG
- DOMObjectVisitor domObjectVisitor;
- visitDOMObjects(&domObjectVisitor);
-#endif
+ v8::HandleScope scope;
// Run through all objects with possible pending activity making their
// wrappers non weak if there is pending activity.
@@ -442,17 +427,11 @@
#endif
#ifndef NDEBUG
- // Check all survivals are weak.
- DOMObjectVisitor domObjectVisitor;
- visitDOMObjects(&domObjectVisitor);
-
EnsureWeakDOMNodeVisitor weakDOMNodeVisitor;
visitDOMNodes(&weakDOMNodeVisitor);
#endif
-#if PLATFORM(CHROMIUM)
TRACE_EVENT_END0("v8", "GC");
-#endif
}
void V8GCController::checkMemoryUsage()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
