Title: [131902] trunk
- Revision
- 131902
- Author
- [email protected]
- Date
- 2012-10-19 08:22:34 -0700 (Fri, 19 Oct 2012)
Log Message
[WK2][GTK] Fullscreen tests timing out in bots
https://bugs.webkit.org/show_bug.cgi?id=93973
Reviewed by Philippe Normand.
Tools:
Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
injected bundle library. webcore_cppflags contains all the feature
defines' macros so the ENABE(*) compilation guards should now work
properly (i.e. enable the code behind them when the feature is enabled).
* WebKitTestRunner/GNUmakefile.am:
LayoutTests:
Remove failure expectations for the fullscreen tests. They all pass now,
with a pass expectation needed for one test to aknowledge that.
* platform/gtk-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131901 => 131902)
--- trunk/LayoutTests/ChangeLog 2012-10-19 15:14:39 UTC (rev 131901)
+++ trunk/LayoutTests/ChangeLog 2012-10-19 15:22:34 UTC (rev 131902)
@@ -1,3 +1,15 @@
+2012-10-19 Zan Dobersek <[email protected]>
+
+ [WK2][GTK] Fullscreen tests timing out in bots
+ https://bugs.webkit.org/show_bug.cgi?id=93973
+
+ Reviewed by Philippe Normand.
+
+ Remove failure expectations for the fullscreen tests. They all pass now,
+ with a pass expectation needed for one test to aknowledge that.
+
+ * platform/gtk-wk2/TestExpectations:
+
2012-10-19 Kent Tamura <[email protected]>
[Chromium] Test expectation update
Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (131901 => 131902)
--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2012-10-19 15:14:39 UTC (rev 131901)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2012-10-19 15:22:34 UTC (rev 131902)
@@ -343,38 +343,6 @@
# Fullscreen tests failing. Some of them are really slow, mark them as SLOW once
# we have lower values for normal and slow time out.
# http://webkit.org/b/93973
-webkit.org/b/93973 fullscreen/anonymous-block-merge-crash.html [ Failure ]
-webkit.org/b/93973 fullscreen/exit-full-screen-iframe.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-cancel.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-crash-offsetLeft.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-css.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-element-stack.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-fixed-pos-parent.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-iframe-allowed.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-iframe-legacy.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-iframe-zIndex.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-keyboard-disabled.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-keyboard-enabled.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-line-boxes-crash.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-placeholder.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-remove-ancestor-after.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-remove-ancestor.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-remove-children.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-remove.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-remove-sibling.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-render-inline.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-request.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-restrictions.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-stacking-context.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-twice.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-zIndex-after.html [ Failure ]
-webkit.org/b/93973 fullscreen/full-screen-zIndex.html [ Failure ]
-webkit.org/b/93973 fullscreen/non-ancestor-iframe.html [ Failure ]
-webkit.org/b/93973 fullscreen/parent-flow-inline-with-block-child.html [ Failure ]
-webkit.org/b/93973 fullscreen/video-controls-override.html [ Failure ]
-webkit.org/b/93973 fullscreen/video-controls-timeline.html [ Failure ]
-webkit.org/b/93973 fullscreen/video-specified-size.html [ Failure ]
# HiDPI - 1 pixel diffs
# http://webkit.org/b/93978
@@ -612,6 +580,7 @@
Bug(GTK) svg/dom/viewspec-parser-3.html [ Pass ]
Bug(GTK) svg/dom/viewspec-parser-4.html [ Pass ]
Bug(GTK) svg/dom/viewspec-parser-5.html [ Pass ]
+Bug(GTK) fullscreen/full-screen-keyboard-enabled.html [ Pass ]
# Will need rebaselining after bug 98527 fixed
webkit.org/b/98527 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
Modified: trunk/Tools/ChangeLog (131901 => 131902)
--- trunk/Tools/ChangeLog 2012-10-19 15:14:39 UTC (rev 131901)
+++ trunk/Tools/ChangeLog 2012-10-19 15:22:34 UTC (rev 131902)
@@ -1,3 +1,17 @@
+2012-10-19 Zan Dobersek <[email protected]>
+
+ [WK2][GTK] Fullscreen tests timing out in bots
+ https://bugs.webkit.org/show_bug.cgi?id=93973
+
+ Reviewed by Philippe Normand.
+
+ Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
+ injected bundle library. webcore_cppflags contains all the feature
+ defines' macros so the ENABE(*) compilation guards should now work
+ properly (i.e. enable the code behind them when the feature is enabled).
+
+ * WebKitTestRunner/GNUmakefile.am:
+
2012-10-19 Simon Hausmann <[email protected]>
Unreviewed, rolling out r131734.
Modified: trunk/Tools/WebKitTestRunner/GNUmakefile.am (131901 => 131902)
--- trunk/Tools/WebKitTestRunner/GNUmakefile.am 2012-10-19 15:14:39 UTC (rev 131901)
+++ trunk/Tools/WebKitTestRunner/GNUmakefile.am 2012-10-19 15:22:34 UTC (rev 131902)
@@ -42,6 +42,7 @@
-I$(top_builddir)/DerivedSources/WebKit2/include \
$(global_cppflags) \
$(_javascript_core_cppflags) \
+ $(webcore_cppflags) \
$(GLOBALDEPS_CFLAGS) \
$(CAIRO_CFLAGS) \
$(GTK_CFLAGS) \
@@ -136,6 +137,7 @@
-I$(top_builddir)/DerivedSources/WebKit2/include \
$(global_cppflags) \
$(_javascript_core_cppflags) \
+ $(webcore_cppflags) \
$(GLOBALDEPS_CFLAGS) \
$(CAIRO_CFLAGS) \
$(GLIB_CFLAGS) \
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
