Title: [131916] trunk/Source/WebKit2
Revision
131916
Author
[email protected]
Date
2012-10-19 10:25:25 -0700 (Fri, 19 Oct 2012)

Log Message

REGRESSION (r131686): Crash in NSToolTipManager mouseEnteredToolTip
<rdar://problem/12527528> and https://bugs.webkit.org/show_bug.cgi?id=99792

Patch by Darin Adler, reviewed by Brady Eidson.

We should explicitly remove tooltips when the view moves to a new window.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (131915 => 131916)


--- trunk/Source/WebKit2/ChangeLog	2012-10-19 17:16:19 UTC (rev 131915)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-19 17:25:25 UTC (rev 131916)
@@ -1,3 +1,15 @@
+2012-10-19  Brady Eidson  <[email protected]>
+
+        REGRESSION (r131686): Crash in NSToolTipManager mouseEnteredToolTip
+        <rdar://problem/12527528> and https://bugs.webkit.org/show_bug.cgi?id=99792
+
+        Patch by Darin Adler, reviewed by Brady Eidson.
+
+        We should explicitly remove tooltips when the view moves to a new window.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView viewDidMoveToWindow]):
+
 2012-10-19  Balazs Kelemen  <[email protected]>
 
         [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active

Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (131915 => 131916)


--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2012-10-19 17:16:19 UTC (rev 131915)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2012-10-19 17:25:25 UTC (rev 131916)
@@ -1921,6 +1921,8 @@
 
 - (void)viewDidMoveToWindow
 {
+    [self removeAllToolTips];
+    
     // We want to make sure to update the active state while hidden, so if the view is about to become visible, we
     // update the active state first and then make it visible. If the view is about to be hidden, we hide it first and then
     // update the active state.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to