Title: [132290] trunk/Source/WebKit/blackberry
- Revision
- 132290
- Author
- commit-qu...@webkit.org
- Date
- 2012-10-23 18:57:10 -0700 (Tue, 23 Oct 2012)
Log Message
[BlackBerry] Web page renders at the wrong zoom level after viewport changes
https://bugs.webkit.org/show_bug.cgi?id=100096
Patch by Robin Cao <robin....@torchmobile.com.cn> on 2012-10-23
Reviewed by Rob Buis.
Notify the client of the zoom level change before resuming screen updates.
Otherwise, the user interface thread may blit the content at the wrong
zoom level in some cases. This can also prevent potential flickering.
Reviewed internally by Arvid Nilsson.
PR #225741
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (132289 => 132290)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-24 01:48:10 UTC (rev 132289)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-24 01:57:10 UTC (rev 132290)
@@ -1289,6 +1289,8 @@
m_backingStore->d->clearVisibleZoom();
}
+ m_client->zoomChanged(m_webPage->isMinZoomed(), m_webPage->isMaxZoomed(), !shouldZoomOnEscape(), currentScale());
+
// Clear window to make sure there are no artifacts.
if (shouldRender) {
// Resume all screen updates to the backingstore and render+blit visible contents to screen.
@@ -1298,8 +1300,6 @@
m_backingStore->d->resumeScreenAndBackingStoreUpdates(BackingStore::None);
}
- m_client->zoomChanged(m_webPage->isMinZoomed(), m_webPage->isMaxZoomed(), !shouldZoomOnEscape(), currentScale());
-
return true;
}
@@ -3054,8 +3054,8 @@
}
notifyTransformChanged();
+ m_client->zoomChanged(m_webPage->isMinZoomed(), m_webPage->isMaxZoomed(), !shouldZoomOnEscape(), currentScale());
m_backingStore->d->resumeScreenAndBackingStoreUpdates(BackingStore::RenderAndBlit);
- m_client->zoomChanged(m_webPage->isMinZoomed(), m_webPage->isMaxZoomed(), !shouldZoomOnEscape(), currentScale());
}
void WebPage::blockZoomAnimationFinished()
Modified: trunk/Source/WebKit/blackberry/ChangeLog (132289 => 132290)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-10-24 01:48:10 UTC (rev 132289)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-10-24 01:57:10 UTC (rev 132290)
@@ -1,3 +1,22 @@
+2012-10-23 Robin Cao <robin....@torchmobile.com.cn>
+
+ [BlackBerry] Web page renders at the wrong zoom level after viewport changes
+ https://bugs.webkit.org/show_bug.cgi?id=100096
+
+ Reviewed by Rob Buis.
+
+ Notify the client of the zoom level change before resuming screen updates.
+ Otherwise, the user interface thread may blit the content at the wrong
+ zoom level in some cases. This can also prevent potential flickering.
+
+ Reviewed internally by Arvid Nilsson.
+
+ PR #225741
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
+ (BlackBerry::WebKit::WebPagePrivate::zoomBlock):
+
2012-10-23 Mike Lattanzio <mlattan...@rim.com>
[BlackBerry] Cache TouchDown HitTestResult to avoid calling RenderLayer::hitTest unnecessarily
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
