Title: [132315] trunk/Source/WebCore
- Revision
- 132315
- Author
- yu...@chromium.org
- Date
- 2012-10-23 23:35:30 -0700 (Tue, 23 Oct 2012)
Log Message
Memory instrumentation: don't count agent-specific front-ends separately
https://bugs.webkit.org/show_bug.cgi?id=100087
Reviewed by Alexander Pavlov.
Pointers to domain-specific inspector front-end interfaces are reported as
weak pointers instead of members to avoid double-counting.
Test by comparing set of reported instrumented objects with the set of objects
allocated by tcmalloc.
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132314 => 132315)
--- trunk/Source/WebCore/ChangeLog 2012-10-24 06:27:08 UTC (rev 132314)
+++ trunk/Source/WebCore/ChangeLog 2012-10-24 06:35:30 UTC (rev 132315)
@@ -1,3 +1,23 @@
+2012-10-23 Yury Semikhatsky <yu...@chromium.org>
+
+ Memory instrumentation: don't count agent-specific front-ends separately
+ https://bugs.webkit.org/show_bug.cgi?id=100087
+
+ Reviewed by Alexander Pavlov.
+
+ Pointers to domain-specific inspector front-end interfaces are reported as
+ weak pointers instead of members to avoid double-counting.
+
+ Test by comparing set of reported instrumented objects with the set of objects
+ allocated by tcmalloc.
+
+ * inspector/InspectorDOMStorageAgent.cpp:
+ (WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
+ * inspector/InspectorDOMStorageResource.cpp:
+ (WebCore::InspectorDOMStorageResource::reportMemoryUsage):
+ * inspector/InspectorProfilerAgent.cpp:
+ (WebCore::InspectorProfilerAgent::reportMemoryUsage):
+
2012-10-23 Christophe Dumez <christophe.du...@intel.com>
Regression(r132303) Broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled
Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp (132314 => 132315)
--- trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp 2012-10-24 06:27:08 UTC (rev 132314)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp 2012-10-24 06:35:30 UTC (rev 132315)
@@ -228,7 +228,7 @@
MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::InspectorDOMStorageAgent);
InspectorBaseAgent<InspectorDOMStorageAgent>::reportMemoryUsage(memoryObjectInfo);
info.addMember(m_resources);
- info.addMember(m_frontend);
+ info.addWeakPointer(m_frontend);
}
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp (132314 => 132315)
--- trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp 2012-10-24 06:27:08 UTC (rev 132314)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp 2012-10-24 06:35:30 UTC (rev 132315)
@@ -90,7 +90,7 @@
MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::InspectorDOMStorageResources);
info.addMember(m_storageArea);
info.addMember(m_frame);
- info.addMember(m_frontend);
+ info.addWeakPointer(m_frontend);
info.addMember(m_id);
info.addPrivateBuffer(m_storageArea->memoryBytesUsedByCache());
}
Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp (132314 => 132315)
--- trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2012-10-24 06:27:08 UTC (rev 132314)
+++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2012-10-24 06:35:30 UTC (rev 132315)
@@ -490,7 +490,7 @@
InspectorBaseAgent<InspectorProfilerAgent>::reportMemoryUsage(memoryObjectInfo);
info.addMember(m_consoleAgent);
info.addMember(m_injectedScriptManager);
- info.addMember(m_frontend);
+ info.addWeakPointer(m_frontend);
info.addMember(m_profiles);
info.addMember(m_snapshots);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
