Diff
Modified: trunk/LayoutTests/ChangeLog (132337 => 132338)
--- trunk/LayoutTests/ChangeLog 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/LayoutTests/ChangeLog 2012-10-24 12:05:32 UTC (rev 132338)
@@ -1,3 +1,17 @@
+2012-10-24 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r132333.
+ http://trac.webkit.org/changeset/132333
+ https://bugs.webkit.org/show_bug.cgi?id=100234
+
+ Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
+ #webkit).
+
+ * platform/efl-wk2/TestExpectations:
+ * platform/efl/TestExpectations:
+ * platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
+ * platform/efl/editing/spelling/spelling-expected.txt: Removed.
+
2012-10-24 Grzegorz Czajkowski <[email protected]>
[EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
Modified: trunk/LayoutTests/platform/efl/TestExpectations (132337 => 132338)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-10-24 12:05:32 UTC (rev 132338)
@@ -917,6 +917,8 @@
editing/selection/word-granularity.html [ Missing ]
editing/selection/wrapped-line-caret-1.html [ Missing ]
editing/selection/wrapped-line-caret-2.html [ Missing ]
+editing/spelling/inline_spelling_markers.html [ Missing ]
+editing/spelling/spelling.html [ Missing ]
editing/style/4916887.html [ Missing ]
editing/style/5017613-1.html [ Missing ]
editing/style/5017613-2.html [ Missing ]
@@ -1774,6 +1776,19 @@
# Tests failing due to rounding problems in colors inside pixman
webkit.org/b/49964 fast/canvas/canvas-fillPath-shadow.html [ Failure ]
+# Missing spell checking support (Efl's port does not support spell checking, Gtk port uses Enchant library https://bugs.webkit.org/show_bug.cgi?id=61787)
+webkit.org/b/86637 editing/spelling/grammar.html [ Failure ]
+webkit.org/b/86637 editing/spelling/grammar-paste.html [ Failure ]
+webkit.org/b/86637 editing/spelling/markers.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spellcheck-attribute.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-attribute-at-child.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-attribute-change.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-backspace-between-lines.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-hasspellingmarker.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-insert-html.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-linebreak.html [ Failure ]
+webkit.org/b/86633 editing/spelling/spelling-unified-emulation.html [ Failure ]
+
# EFL's LayoutTestController does not support setSubpixelTextPositioning()
webkit.org/b/91341 fast/text/descent-clip-in-scaled-page.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (132337 => 132338)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-24 12:05:32 UTC (rev 132338)
@@ -28,13 +28,6 @@
#////////////////////////////////////////////////////////////////////////////////////////
# PASSING TESTS
#////////////////////////////////////////////////////////////////////////////////////////
-editing/spelling/design-mode-spellcheck-off.html [ Pass ]
-editing/spelling/spellcheck-api-crash.html [ Pass ]
-editing/spelling/spellcheck-attribute.html [ Pass ]
-editing/spelling/spelling-attribute-at-child.html [ Pass ]
-editing/spelling/spelling-attribute-change.html [ Pass ]
-editing/spelling/spelling-hasspellingmarker.html [ Pass ]
-editing/spelling/spelling-linebreak.html [ Pass ]
#////////////////////////////////////////////////////////////////////////////////////////
# TESTS EXPECTED TO FAIL
@@ -195,13 +188,6 @@
Bug(EFL) fast/media/media-query-list-07.html [ Failure ]
Bug(EFL) fast/media/view-mode-media-feature.html [ Failure ]
-# Needs grammar checking
-Bug(EFL) editing/spelling/grammar-edit-word.html [ Failure ]
-Bug(EFL) editing/spelling/markers.html [ Failure ]
-
-# Unified text checking is failing
-Bug(EFL) editing/spelling/spelling-unified-emulation.html [ Failure ]
-
# WebKitTestRunner needs an implementation for eventSender.scheduleAsynchronousKeyDown
webkit.org/b/93979 fast/mutation/end-of-task-delivery.html [ Failure ]
@@ -275,3 +261,6 @@
# Flaky on EFL port.
webkit.org/b/96641 media/video-seek-past-end-playing.html [ Failure ]
+
+# EFL WK2 does not support the spellchecker feature
+webkit.org/b/91854 editing/spelling [ Skip ]
Modified: trunk/Source/WebKit2/ChangeLog (132337 => 132338)
--- trunk/Source/WebKit2/ChangeLog 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-24 12:05:32 UTC (rev 132338)
@@ -1,3 +1,16 @@
+2012-10-24 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r132333.
+ http://trac.webkit.org/changeset/132333
+ https://bugs.webkit.org/show_bug.cgi?id=100234
+
+ Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
+ #webkit).
+
+ * Target.pri:
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::updateTextCheckerState):
+
2012-10-24 Christophe Dumez <[email protected]> and Mikhail Pozdnyakov <[email protected]>
[EFL][WK2] Move Ewk_View_Private_Data out of ewk_view.cpp
Modified: trunk/Source/WebKit2/Target.pri (132337 => 132338)
--- trunk/Source/WebKit2/Target.pri 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Source/WebKit2/Target.pri 2012-10-24 12:05:32 UTC (rev 132338)
@@ -170,7 +170,6 @@
UIProcess/API/C/WKGeolocationManager.h \
UIProcess/API/C/WKGeolocationPermissionRequest.h \
UIProcess/API/C/WKGeolocationPosition.h \
- UIProcess/API/C/WKGrammarDetail.h \
UIProcess/API/C/WKHitTestResult.h \
UIProcess/API/C/WKIconDatabase.h \
UIProcess/API/C/WKInspector.h \
@@ -193,7 +192,6 @@
UIProcess/API/C/WKPreferencesPrivate.h \
UIProcess/API/C/WKProtectionSpace.h \
UIProcess/API/C/WKProtectionSpaceTypes.h \
- UIProcess/API/C/WKTextChecker.h \
UIProcess/API/C/WKVibration.h \
UIProcess/API/C/WebKit2_C.h \
UIProcess/API/C/qt/WKNativeEvent.h \
@@ -261,7 +259,6 @@
UIProcess/WebFullScreenManagerProxy.h \
UIProcess/WebGeolocationManagerProxy.h \
UIProcess/WebGeolocationProvider.h \
- UIProcess/WebGrammarDetail.h \
UIProcess/WebHistoryClient.h \
UIProcess/WebIconDatabase.h \
UIProcess/WebIconDatabaseClient.h \
@@ -280,8 +277,6 @@
UIProcess/WebProcessProxy.h \
UIProcess/WebResourceCacheManagerProxy.h \
UIProcess/WebResourceLoadClient.h \
- UIProcess/WebTextChecker.h \
- UIProcess/WebTextCheckerClient.h \
UIProcess/WebUIClient.h \
UIProcess/WebVibrationProvider.h \
UIProcess/WebVibrationProxy.h \
@@ -532,7 +527,6 @@
UIProcess/API/C/WKGeolocationManager.cpp \
UIProcess/API/C/WKGeolocationPermissionRequest.cpp \
UIProcess/API/C/WKGeolocationPosition.cpp \
- UIProcess/API/C/WKGrammarDetail.cpp \
UIProcess/API/C/WKHitTestResult.cpp \
UIProcess/API/C/WKIconDatabase.cpp \
UIProcess/API/C/WKInspector.cpp \
@@ -552,7 +546,6 @@
UIProcess/API/C/WKPreferences.cpp \
UIProcess/API/C/WKProtectionSpace.cpp \
UIProcess/API/C/WKResourceCacheManager.cpp \
- UIProcess/API/C/WKTextChecker.cpp \
UIProcess/API/C/WKVibration.cpp \
UIProcess/API/cpp/qt/WKStringQt.cpp \
UIProcess/API/cpp/qt/WKURLQt.cpp \
@@ -615,7 +608,6 @@
UIProcess/WebFullScreenManagerProxy.cpp \
UIProcess/WebGeolocationManagerProxy.cpp \
UIProcess/WebGeolocationProvider.cpp \
- UIProcess/WebGrammarDetail.cpp \
UIProcess/WebHistoryClient.cpp \
UIProcess/WebIconDatabase.cpp \
UIProcess/WebIconDatabaseClient.cpp \
@@ -636,8 +628,6 @@
UIProcess/WebProcessProxy.cpp \
UIProcess/WebResourceCacheManagerProxy.cpp \
UIProcess/WebResourceLoadClient.cpp \
- UIProcess/WebTextChecker.cpp \
- UIProcess/WebTextCheckerClient.cpp \
UIProcess/WebUIClient.cpp \
UIProcess/WebVibrationProvider.cpp \
UIProcess/WebVibrationProxy.cpp \
Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (132337 => 132338)
--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2012-10-24 12:05:32 UTC (rev 132338)
@@ -594,8 +594,10 @@
void WebProcessProxy::updateTextCheckerState()
{
- if (canSendMessage())
- send(Messages::WebProcess::SetTextCheckerState(TextChecker::state()), 0);
+ if (!isValid())
+ return;
+
+ send(Messages::WebProcess::SetTextCheckerState(TextChecker::state()), 0);
}
void WebProcessProxy::didNavigateWithNavigationData(uint64_t pageID, const WebNavigationDataStore& store, uint64_t frameID)
Modified: trunk/Tools/ChangeLog (132337 => 132338)
--- trunk/Tools/ChangeLog 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Tools/ChangeLog 2012-10-24 12:05:32 UTC (rev 132338)
@@ -1,3 +1,17 @@
+2012-10-24 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r132333.
+ http://trac.webkit.org/changeset/132333
+ https://bugs.webkit.org/show_bug.cgi?id=100234
+
+ Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
+ #webkit).
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetStateToConsistentValues):
+ * WebKitTestRunner/efl/TestControllerEfl.cpp:
+ (WTR::TestController::platformInitializeContext):
+
2012-10-24 Dongwoo Joshua Im <[email protected]>
[GTK] Fix build break - undefined reference to 'gtk_init'
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (132337 => 132338)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-24 12:05:32 UTC (rev 132338)
@@ -53,10 +53,6 @@
#include "EventSenderProxy.h"
#endif
-#if !PLATFORM(MAC)
-#include <WebKit2/WKTextChecker.h>
-#endif
-
namespace WTR {
// defaultLongTimeout + defaultShortTimeout should be less than 80,
@@ -534,9 +530,6 @@
#endif
WKPreferencesSetScreenFontSubstitutionEnabled(preferences, true);
WKPreferencesSetInspectorUsesWebKitUserInterface(preferences, true);
-#if !PLATFORM(MAC)
- WKTextCheckerContinuousSpellCheckingEnabledStateChanged(true);
-#endif
// in the case that a test using the chrome input field failed, be sure to clean up for the next test
m_mainWebView->removeChromeInputField();
Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (132337 => 132338)
--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-10-24 12:02:28 UTC (rev 132337)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2012-10-24 12:05:32 UTC (rev 132338)
@@ -27,11 +27,6 @@
#include <wtf/Platform.h>
#include <wtf/text/WTFString.h>
-#if ENABLE(SPELLCHECK)
-#include <WebKit2/ewk_settings.h>
-#include <WebKit2/ewk_text_checker_private.h>
-#endif
-
namespace WTR {
static Ecore_Timer* timer = 0;
@@ -101,11 +96,6 @@
void TestController::platformInitializeContext()
{
-#if ENABLE(SPELLCHECK)
- ewk_text_checker_client_attach();
- // Loads the default language (en_US) to pass the spelling tests.
- ewk_settings_spell_checking_languages_set(0);
-#endif
}
void TestController::runModal(PlatformWebView*)
