Title: [132342] trunk/Tools
- Revision
- 132342
- Author
- [email protected]
- Date
- 2012-10-24 05:38:10 -0700 (Wed, 24 Oct 2012)
Log Message
[EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=100010
Reviewed by Kenneth Rohde Christiansen.
Force the main view to receive focus even if Evas already
considers it to be focused.
It might happen that a different frame is focused by a page and
the focus change notification does not reach Evas. When another
test is run, the main frame is then not considered to be focused
by WebCore, and things such as focus rings are not drawn as
expected.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (132341 => 132342)
--- trunk/Tools/ChangeLog 2012-10-24 12:31:51 UTC (rev 132341)
+++ trunk/Tools/ChangeLog 2012-10-24 12:38:10 UTC (rev 132342)
@@ -1,3 +1,22 @@
+2012-10-24 Raphael Kubo da Costa <[email protected]>
+
+ [EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=100010
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Force the main view to receive focus even if Evas already
+ considers it to be focused.
+
+ It might happen that a different frame is focused by a page and
+ the focus change notification does not reach Evas. When another
+ test is run, the main frame is then not considered to be focused
+ by WebCore, and things such as focus rings are not drawn as
+ expected.
+
+ * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+ (WTR::PlatformWebView::focus):
+
2012-10-24 Sheriff Bot <[email protected]>
Unreviewed, rolling out r132333.
Modified: trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp (132341 => 132342)
--- trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2012-10-24 12:31:51 UTC (rev 132341)
+++ trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2012-10-24 12:38:10 UTC (rev 132342)
@@ -69,6 +69,11 @@
void PlatformWebView::focus()
{
+ // Force the view to receive focus even if Evas considers it to be focused; sometimes an iframe might receive
+ // focused via _javascript_ and the main frame is considered unfocused, but that is not noticed by Evas.
+ // Perhaps WebCoreSupport::focusedFrameChanged() should emit some sort of notification?
+ if (evas_object_focus_get(m_view))
+ evas_object_focus_set(m_view, false);
evas_object_focus_set(m_view, true);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
