Modified: trunk/Source/WebCore/ChangeLog (132451 => 132452)
--- trunk/Source/WebCore/ChangeLog 2012-10-25 06:42:27 UTC (rev 132451)
+++ trunk/Source/WebCore/ChangeLog 2012-10-25 06:47:39 UTC (rev 132452)
@@ -1,5 +1,27 @@
2012-10-24 Kent Tamura <[email protected]>
+ Minimize CSS rulesets for multiple-fields input
+ https://bugs.webkit.org/show_bug.cgi?id=100198
+
+ Reviewed by Kentaro Hara.
+
+ - Unify rulesets for input::-webkit-datetime-edit-*-field.
+ input::-webkit-datetime-edit-*-field had identical ruleset.
+
+ - Move some rulesets near to related rulesets.
+ Move -webkit-datetime-edit-*-field:focus nearby the new unified ruleset.
+ Move input::-webkit-datetime-edit-second-field[readonly] nearby
+ input::-webkit-datetime-edit-minute-field[readonly].
+
+ No new tests. This shouldn't make any behavior change.
+
+ * css/html.css:
+ (input::-webkit-datetime-edit-year-field):
+ (input::-webkit-datetime-edit-year-field:focus):
+ (input::-webkit-datetime-edit-second-field[readonly]):
+
+2012-10-24 Kent Tamura <[email protected]>
+
REGRESSION(r132291): Crash in BaseMultipleFieldsDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=100326
Modified: trunk/Source/WebCore/css/html.css (132451 => 132452)
--- trunk/Source/WebCore/css/html.css 2012-10-25 06:42:27 UTC (rev 132451)
+++ trunk/Source/WebCore/css/html.css 2012-10-25 06:47:39 UTC (rev 132452)
@@ -539,7 +539,15 @@
white-space: pre;
}
-input::-webkit-datetime-edit-ampm-field {
+input::-webkit-datetime-edit-ampm-field,
+input::-webkit-datetime-edit-day-field,
+input::-webkit-datetime-edit-hour-field,
+input::-webkit-datetime-edit-millisecond-field,
+input::-webkit-datetime-edit-minute-field,
+input::-webkit-datetime-edit-month-field,
+input::-webkit-datetime-edit-second-field,
+input::-webkit-datetime-edit-week-field,
+input::-webkit-datetime-edit-year-field {
-webkit-user-modify: read-only !important;
border: none;
display: inline-block;
@@ -547,75 +555,31 @@
text-align: center;
}
-input::-webkit-datetime-edit-day-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
+/* Remove focus ring from fields and use highlight color */
+input::-webkit-datetime-edit-ampm-field:focus,
+input::-webkit-datetime-edit-day-field:focus,
+input::-webkit-datetime-edit-hour-field:focus,
+input::-webkit-datetime-edit-millisecond-field:focus,
+input::-webkit-datetime-edit-minute-field:focus,
+input::-webkit-datetime-edit-month-field:focus,
+input::-webkit-datetime-edit-second-field:focus,
+input::-webkit-datetime-edit-week-field:focus,
+input::-webkit-datetime-edit-year-field:focus {
+ background-color: highlight;
+ color: highlighttext;
+ outline: none;
}
-input::-webkit-datetime-edit-hour-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
-input::-webkit-datetime-edit-millisecond-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
-input::-webkit-datetime-edit-minute-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
-input::-webkit-datetime-edit-month-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
/* This selector is used when step >= 3600 second but format contains minute field. */
input::-webkit-datetime-edit-minute-field[readonly] {
color: GrayText;
}
-input::-webkit-datetime-edit-second-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
+/* This selector is used when step >= 60 second but format contains second field. */
+input::-webkit-datetime-edit-second-field[readonly] {
+ color: GrayText;
}
-input::-webkit-datetime-edit-week-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
-input::-webkit-datetime-edit-year-field {
- -webkit-user-modify: read-only !important;
- display: inline-block;
- border: none;
- margin: 1px;
- text-align: center;
-}
-
input::-webkit-datetime-edit-text {
-webkit-user-modify: read-only !important;
display: inline-block;
@@ -627,26 +591,6 @@
display: -webkit-inline-flex;
}
-/* Remove focus ring from fields and use highlight color */
-input::-webkit-datetime-edit-ampm-field:focus,
-input::-webkit-datetime-edit-day-field:focus,
-input::-webkit-datetime-edit-hour-field:focus,
-input::-webkit-datetime-edit-millisecond-field:focus,
-input::-webkit-datetime-edit-minute-field:focus,
-input::-webkit-datetime-edit-month-field:focus,
-input::-webkit-datetime-edit-second-field:focus,
-input::-webkit-datetime-edit-week-field:focus,
-input::-webkit-datetime-edit-year-field:focus {
- background-color: highlight;
- color: highlighttext;
- outline: none;
-}
-
-/* This selector is used when step >= 60 second but format contains second field. */
-input::-webkit-datetime-edit-second-field[readonly] {
- color: GrayText;
-}
-
input[type="date"]::-webkit-inner-spin-button,
input[type="datetime"]::-webkit-inner-spin-button,
input[type="datetime-local"]::-webkit-inner-spin-button,
