Title: [132471] trunk/Tools
Revision
132471
Author
[email protected]
Date
2012-10-25 04:57:48 -0700 (Thu, 25 Oct 2012)

Log Message

[EFL][WK2] _javascript_ popups are not focused when opened
https://bugs.webkit.org/show_bug.cgi?id=100354

Patch by Sudarsana Nagineni <[email protected]> on 2012-10-25
Reviewed by Kenneth Rohde Christiansen.

Move focus to the _javascript_ popups when opened so that the key events
are forwarded to the popups instead of web view.

* MiniBrowser/efl/main.c:
(on_javascript_alert):
(on_javascript_confirm):
(on_javascript_prompt):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (132470 => 132471)


--- trunk/Tools/ChangeLog	2012-10-25 11:57:44 UTC (rev 132470)
+++ trunk/Tools/ChangeLog	2012-10-25 11:57:48 UTC (rev 132471)
@@ -1,3 +1,18 @@
+2012-10-25  Sudarsana Nagineni  <[email protected]>
+
+        [EFL][WK2] _javascript_ popups are not focused when opened
+        https://bugs.webkit.org/show_bug.cgi?id=100354
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Move focus to the _javascript_ popups when opened so that the key events
+        are forwarded to the popups instead of web view.
+
+        * MiniBrowser/efl/main.c:
+        (on_javascript_alert):
+        (on_javascript_confirm):
+        (on_javascript_prompt):
+
 2012-10-25  Eugene Klyuchnikov  <[email protected]>
 
         Web Inspector: Fix "check-inspector-strings" script and fix localized strings.

Modified: trunk/Tools/MiniBrowser/efl/main.c (132470 => 132471)


--- trunk/Tools/MiniBrowser/efl/main.c	2012-10-25 11:57:44 UTC (rev 132470)
+++ trunk/Tools/MiniBrowser/efl/main.c	2012-10-25 11:57:48 UTC (rev 132471)
@@ -465,6 +465,7 @@
     elm_object_text_set(button, "OK");
     elm_object_part_content_set(alert_popup, "button1", button);
     evas_object_smart_callback_add(button, "clicked", quit_event_loop, NULL);
+    elm_object_focus_set(button, EINA_TRUE);
     evas_object_show(alert_popup);
 
     /* Make modal */
@@ -494,6 +495,7 @@
     elm_object_text_set(ok_button, "OK");
     elm_object_part_content_set(confirm_popup, "button2", ok_button);
     evas_object_smart_callback_add(ok_button, "clicked", on_ok_clicked, &ok);
+    elm_object_focus_set(ok_button, EINA_TRUE);
     evas_object_show(confirm_popup);
 
     /* Make modal */
@@ -534,9 +536,11 @@
     elm_entry_single_line_set(entry, EINA_TRUE);
     elm_entry_text_style_user_push(entry, "DEFAULT='font_size=18'");
     elm_entry_entry_set(entry, default_value ? default_value : "");
+    elm_entry_select_all(entry);
     evas_object_size_hint_weight_set(entry, EVAS_HINT_EXPAND, 0.0);
     evas_object_size_hint_align_set(entry, EVAS_HINT_FILL, 0.5);
     elm_box_pack_end(box, entry);
+    elm_object_focus_set(entry, EINA_TRUE);
     evas_object_show(entry);
 
     elm_object_content_set(prompt_popup, box);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to