Title: [132485] trunk/Source/WebKit2
Revision
132485
Author
[email protected]
Date
2012-10-25 08:19:29 -0700 (Thu, 25 Oct 2012)

Log Message

[EFL][WK2] Memory leak in _ewk_view_preedit_changed()
https://bugs.webkit.org/show_bug.cgi?id=100380

Patch by Christophe Dumez <[email protected]> on 2012-10-25
Reviewed by Antonio Gomes.

Fix memory leak in _ewk_view_preedit_changed(). The buffer
returned by ecore_imf_context_preedit_string_get() is never
freed.

* UIProcess/API/efl/EwkViewImpl.cpp:
(_ewk_view_preedit_changed):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (132484 => 132485)


--- trunk/Source/WebKit2/ChangeLog	2012-10-25 14:51:50 UTC (rev 132484)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-25 15:19:29 UTC (rev 132485)
@@ -1,3 +1,17 @@
+2012-10-25  Christophe Dumez  <[email protected]>
+
+        [EFL][WK2] Memory leak in _ewk_view_preedit_changed()
+        https://bugs.webkit.org/show_bug.cgi?id=100380
+
+        Reviewed by Antonio Gomes.
+
+        Fix memory leak in _ewk_view_preedit_changed(). The buffer
+        returned by ecore_imf_context_preedit_string_get() is never
+        freed.
+
+        * UIProcess/API/efl/EwkViewImpl.cpp:
+        (_ewk_view_preedit_changed):
+
 2012-10-25  Yael Aharon  <[email protected]>
 
         [EFL][WK2][AC] Regression(132392) infinite loop when displaying certain animations.

Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (132484 => 132485)


--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp	2012-10-25 14:51:50 UTC (rev 132484)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp	2012-10-25 15:19:29 UTC (rev 132485)
@@ -101,6 +101,7 @@
         return;
 
     String preeditString = String::fromUTF8(buffer);
+    free(buffer);
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, preeditString.length(), Color(0, 0, 0), false));
     viewImpl->pageProxy->setComposition(preeditString, underlines, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to