Title: [132494] trunk
Revision
132494
Author
[email protected]
Date
2012-10-25 09:30:35 -0700 (Thu, 25 Oct 2012)

Log Message

Web Inspector: inspector tests failing after r132454
https://bugs.webkit.org/show_bug.cgi?id=100381

Reviewed by Pavel Feldman.

Source/WebCore:

Added implementation for DOMNodeWrapperMap::reportMemoryUsage method,
otherwise no actual pointer is reported which breaks instrumentation.

* bindings/v8/IntrusiveDOMWrapperMap.h:

LayoutTests:

Enable memory instrumentation tests now that the problem is fixed.

* platform/chromium/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (132493 => 132494)


--- trunk/LayoutTests/ChangeLog	2012-10-25 16:28:48 UTC (rev 132493)
+++ trunk/LayoutTests/ChangeLog	2012-10-25 16:30:35 UTC (rev 132494)
@@ -1,3 +1,14 @@
+2012-10-25  Yury Semikhatsky  <[email protected]>
+
+        Web Inspector: inspector tests failing after r132454
+        https://bugs.webkit.org/show_bug.cgi?id=100381
+
+        Reviewed by Pavel Feldman.
+
+        Enable memory instrumentation tests now that the problem is fixed.
+
+        * platform/chromium/TestExpectations:
+
 2012-10-25  Kenneth Rohde Christiansen  <[email protected]>
 
         'resolution' MQ: Printing should use use high resolution images when available

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132493 => 132494)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-25 16:28:48 UTC (rev 132493)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-25 16:30:35 UTC (rev 132494)
@@ -4080,6 +4080,3 @@
 
 Bug(thakis) [ Mac ] css3/filters/custom/effect-custom.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/100381 [ Debug ] inspector/profiler/memory-instrumentation-cached-images.html [ Crash ]
-webkit.org/b/100381 [ Debug ] inspector/profiler/memory-instrumentation-canvas.html [ Crash ]
-

Modified: trunk/Source/WebCore/ChangeLog (132493 => 132494)


--- trunk/Source/WebCore/ChangeLog	2012-10-25 16:28:48 UTC (rev 132493)
+++ trunk/Source/WebCore/ChangeLog	2012-10-25 16:30:35 UTC (rev 132494)
@@ -1,3 +1,15 @@
+2012-10-25  Yury Semikhatsky  <[email protected]>
+
+        Web Inspector: inspector tests failing after r132454
+        https://bugs.webkit.org/show_bug.cgi?id=100381
+
+        Reviewed by Pavel Feldman.
+
+        Added implementation for DOMNodeWrapperMap::reportMemoryUsage method,
+        otherwise no actual pointer is reported which breaks instrumentation.
+
+        * bindings/v8/IntrusiveDOMWrapperMap.h:
+
 2012-10-25  Dominik Röttsches  <[email protected]>
 
         Init timeout flag in ResourceErrorCF

Modified: trunk/Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.h (132493 => 132494)


--- trunk/Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.h	2012-10-25 16:28:48 UTC (rev 132493)
+++ trunk/Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.h	2012-10-25 16:30:35 UTC (rev 132494)
@@ -62,6 +62,7 @@
 
     virtual void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const OVERRIDE
     {
+        MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Binding);
     }
 
 private:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to