Title: [132527] trunk
- Revision
- 132527
- Author
- [email protected]
- Date
- 2012-10-25 13:39:32 -0700 (Thu, 25 Oct 2012)
Log Message
Incorrect tile size in the slow scrolling case
https://bugs.webkit.org/show_bug.cgi?id=100411
Reviewed by Beth Dakin.
Source/WebCore:
If we're in slow scrolling mode, we don't want to inflate the
coverage rect based on scrollability. This ensures that the few
big tiles we create have the correct size.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::computeTileCoverageRect):
LayoutTests:
New result with better tile size.
* platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (132526 => 132527)
--- trunk/LayoutTests/ChangeLog 2012-10-25 20:37:24 UTC (rev 132526)
+++ trunk/LayoutTests/ChangeLog 2012-10-25 20:39:32 UTC (rev 132527)
@@ -1,3 +1,14 @@
+2012-10-25 Simon Fraser <[email protected]>
+
+ Incorrect tile size in the slow scrolling case
+ https://bugs.webkit.org/show_bug.cgi?id=100411
+
+ Reviewed by Beth Dakin.
+
+ New result with better tile size.
+
+ * platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
+
2012-10-25 Roger Fong <[email protected]>
Unreviewed. Skipping inspector/elements/update-shadowdom.html.
Modified: trunk/LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt (132526 => 132527)
--- trunk/LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt 2012-10-25 20:37:24 UTC (rev 132526)
+++ trunk/LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt 2012-10-25 20:39:32 UTC (rev 132527)
@@ -8,7 +8,7 @@
(backgroundColor #FFFFFF)
(visible rect 0.00, 0.00 800.00 x 600.00)
(tile cache coverage 0, 0 800 x 600)
- (tile size 1600 x 1800)
+ (tile size 800 x 600)
(children 1
(GraphicsLayer
(visible rect 0.00, 0.00 0.00 x 0.00)
Modified: trunk/Source/WebCore/ChangeLog (132526 => 132527)
--- trunk/Source/WebCore/ChangeLog 2012-10-25 20:37:24 UTC (rev 132526)
+++ trunk/Source/WebCore/ChangeLog 2012-10-25 20:39:32 UTC (rev 132527)
@@ -1,3 +1,17 @@
+2012-10-25 Simon Fraser <[email protected]>
+
+ Incorrect tile size in the slow scrolling case
+ https://bugs.webkit.org/show_bug.cgi?id=100411
+
+ Reviewed by Beth Dakin.
+
+ If we're in slow scrolling mode, we don't want to inflate the
+ coverage rect based on scrollability. This ensures that the few
+ big tiles we create have the correct size.
+
+ * platform/graphics/ca/mac/TileCache.mm:
+ (WebCore::TileCache::computeTileCoverageRect):
+
2012-10-25 Nico Weber <[email protected]>
Move ImageOrientation transform back in CG space (lower-left origin), adapt the skia code to work with that, turn on feature for chromium
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm (132526 => 132527)
--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-10-25 20:37:24 UTC (rev 132526)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-10-25 20:39:32 UTC (rev 132527)
@@ -318,7 +318,7 @@
// If the page is not in a window (for example if it's in a background tab), we limit the tile coverage rect to the visible rect.
// Furthermore, if the page can't have scrollbars (for example if its body element has overflow:hidden) it's very unlikely that the
// page will ever be scrolled so we limit the tile coverage rect as well.
- if (m_isInWindow) {
+ if (m_isInWindow && !(m_tileCoverage & CoverageForSlowScrolling)) {
// Inflate the coverage rect so that it covers 2x of the visible width and 3x of the visible height.
// These values were chosen because it's more common to have tall pages and to scroll vertically,
// so we keep more tiles above and below the current area.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
