Title: [132561] trunk/Source/WebKit/blackberry
- Revision
- 132561
- Author
- [email protected]
- Date
- 2012-10-25 19:38:05 -0700 (Thu, 25 Oct 2012)
Log Message
[BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
https://bugs.webkit.org/show_bug.cgi?id=100330
Patch by Sean Wang <[email protected]> on 2012-10-25
Reviewed by Rob Buis.
Reviewed internally by Charles Wei.
PR #231232
Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
visible needs AuthenticationChallengeManager to update its records, deleting
webpage from AuthenticationChallengeManager's map should be done after setting
webpage visibility.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (132560 => 132561)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-26 02:37:50 UTC (rev 132560)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-26 02:38:05 UTC (rev 132561)
@@ -453,7 +453,6 @@
WebPagePrivate::~WebPagePrivate()
{
- AuthenticationChallengeManager::instance()->pageDeleted(this);
// Hand the backingstore back to another owner if necessary.
m_webPage->setVisible(false);
if (BackingStorePrivate::currentBackingStoreOwner() == m_webPage)
@@ -494,6 +493,8 @@
delete m_dumpRenderTree;
m_dumpRenderTree = 0;
#endif
+
+ AuthenticationChallengeManager::instance()->pageDeleted(this);
}
WebPage::~WebPage()
Modified: trunk/Source/WebKit/blackberry/ChangeLog (132560 => 132561)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-10-26 02:37:50 UTC (rev 132560)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-10-26 02:38:05 UTC (rev 132561)
@@ -1,3 +1,21 @@
+2012-10-25 Sean Wang <[email protected]>
+
+ [BlackBerry] WebView process crashed at AuthenticationChallengeManager::pageVisibilityChanged()
+ https://bugs.webkit.org/show_bug.cgi?id=100330
+
+ Reviewed by Rob Buis.
+
+ Reviewed internally by Charles Wei.
+ PR #231232
+
+ Since AuthenticationChallengeManager keeps a map of WebPages, WebPage setting
+ visible needs AuthenticationChallengeManager to update its records, deleting
+ webpage from AuthenticationChallengeManager's map should be done after setting
+ webpage visibility.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
+
2012-10-24 Sean Wang <[email protected]>
[BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
