Title: [132569] trunk/Source/WebCore
- Revision
- 132569
- Author
- [email protected]
- Date
- 2012-10-25 21:44:56 -0700 (Thu, 25 Oct 2012)
Log Message
[BlackBerry] User Challenged again after browser restart for HTTP/FTP sites already successfully authenticated.
https://bugs.webkit.org/show_bug.cgi?id=100448
Reviewed by George Staikos.
Internally reviewed by Joe Mason.
We didn't check the persistent Credential Storage for Credentials when challenged by the server.
Manual Test: login to ftp://localhost on BlackBerry device, and restart the browser to login again.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132568 => 132569)
--- trunk/Source/WebCore/ChangeLog 2012-10-26 04:05:48 UTC (rev 132568)
+++ trunk/Source/WebCore/ChangeLog 2012-10-26 04:44:56 UTC (rev 132569)
@@ -1,3 +1,19 @@
+2012-10-25 Charles Wei <[email protected]>
+
+ [BlackBerry] User Challenged again after browser restart for HTTP/FTP sites already successfully authenticated.
+ https://bugs.webkit.org/show_bug.cgi?id=100448
+
+ Reviewed by George Staikos.
+
+ Internally reviewed by Joe Mason.
+
+ We didn't check the persistent Credential Storage for Credentials when challenged by the server.
+
+ Manual Test: login to ftp://localhost on BlackBerry device, and restart the browser to login again.
+
+ * platform/network/blackberry/NetworkJob.cpp:
+ (WebCore::NetworkJob::sendRequestWithCredentials):
+
2012-10-25 Joshua Bell <[email protected]>
IndexedDB: Add histogram statistics for backing store errors
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (132568 => 132569)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-10-26 04:05:48 UTC (rev 132568)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-10-26 04:44:56 UTC (rev 132569)
@@ -770,8 +770,12 @@
// Don't overwrite any existing credentials with the empty credential
if (m_handle->getInternal()->m_currentWebChallenge.isNull())
m_handle->getInternal()->m_currentWebChallenge = AuthenticationChallenge(protectionSpace, credential, 0, m_response, ResourceError());
- } else if (!(credential = CredentialStorage::get(protectionSpace)).isEmpty()) {
- // First search the CredentialStorage.
+ } else if (!(credential = CredentialStorage::get(protectionSpace)).isEmpty()
+#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
+ || !(credential = CredentialStorage::getFromPersistentStorage(protectionSpace)).isEmpty()
+#endif
+ ) {
+ // First search the CredentialStorage and Persistent Credential Storage
m_handle->getInternal()->m_currentWebChallenge = AuthenticationChallenge(protectionSpace, credential, 0, m_response, ResourceError());
m_handle->getInternal()->m_currentWebChallenge.setStored(true);
} else {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
