Title: [132586] trunk
Revision
132586
Author
tk...@chromium.org
Date
2012-10-26 01:39:00 -0700 (Fri, 26 Oct 2012)

Log Message

Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
https://bugs.webkit.org/show_bug.cgi?id=100457

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

It was enabled accidentally. Week input is not implemented in
Android.

* features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.

LayoutTests:

* platform/chromium/TestExpectations:
Tests in fast/forms/week/ may fail on Android.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (132585 => 132586)


--- trunk/LayoutTests/ChangeLog	2012-10-26 08:25:32 UTC (rev 132585)
+++ trunk/LayoutTests/ChangeLog	2012-10-26 08:39:00 UTC (rev 132586)
@@ -1,3 +1,13 @@
+2012-10-26  Kent Tamura  <tk...@chromium.org>
+
+        Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
+        https://bugs.webkit.org/show_bug.cgi?id=100457
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        Tests in fast/forms/week/ may fail on Android.
+
 2012-10-26  Pavel Feldman  <pfeld...@chromium.org>
 
         Not reviewed: chromiuim expectations updated.

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (132585 => 132586)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-26 08:25:32 UTC (rev 132585)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-10-26 08:39:00 UTC (rev 132586)
@@ -1862,8 +1862,6 @@
 webkit.org/b/98782 [ Android ] fast/css/getComputedStyle/computed-style-select-overflow.html [ Failure ]
 
 # [Chromium-Android] Date and time input fields don't have equal functionaliy on Android
-webkit.org/b/98783 [ Android ] fast/forms/week/week-stepup-stepdown-from-renderer.html [ Failure ]
-webkit.org/b/98783 [ Android ] fast/forms/week/week-input-visible-string.html [ Failure ]
 webkit.org/b/98783 [ Android ] fast/forms/time/time-input-visible-string.html [ Failure ]
 webkit.org/b/98783 [ Android ] fast/forms/month/month-stepup-stepdown-from-renderer.html [ Failure ]
 webkit.org/b/98783 [ Android ] fast/forms/month/month-input-visible-string.html [ Failure ]
@@ -1872,6 +1870,9 @@
 webkit.org/b/98783 [ Android ] fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html [ Failure ]
 webkit.org/b/98783 [ Android ] fast/forms/datetime/datetime-input-visible-string.html [ Failure ]
 
+# [Chromium-Android] No <input type=week> implementation.
+crbug.com/135938 [ Android ] fast/forms/week/ [ Failure Pass ]
+
 # [Chromium-Android] image-inside-nested-blocks-with-border.html crashes
 webkit.org/b/98901 [ Android ] fast/multicol/image-inside-nested-blocks-with-border.html [ Crash Pass ]
 

Modified: trunk/Source/WebKit/chromium/ChangeLog (132585 => 132586)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-10-26 08:25:32 UTC (rev 132585)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-10-26 08:39:00 UTC (rev 132586)
@@ -1,5 +1,19 @@
 2012-10-26  Kent Tamura  <tk...@chromium.org>
 
+        Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
+        https://bugs.webkit.org/show_bug.cgi?id=100457
+
+        Reviewed by Kentaro Hara.
+
+        It was enabled accidentally. Week input is not implemented in
+        Android.
+
+        * features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
+        add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
+        ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.
+
+2012-10-26  Kent Tamura  <tk...@chromium.org>
+
         [Chromium-Win] Support shortTimeFormat
         https://bugs.webkit.org/show_bug.cgi?id=100471
 

Modified: trunk/Source/WebKit/chromium/features.gypi (132585 => 132586)


--- trunk/Source/WebKit/chromium/features.gypi	2012-10-26 08:25:32 UTC (rev 132585)
+++ trunk/Source/WebKit/chromium/features.gypi	2012-10-26 08:39:00 UTC (rev 132586)
@@ -75,7 +75,6 @@
       'ENABLE_INPUT_TYPE_DATETIMELOCAL=1',
       'ENABLE_INPUT_TYPE_MONTH=1',
       'ENABLE_INPUT_TYPE_TIME=1',
-      'ENABLE_INPUT_TYPE_WEEK=1',
       'ENABLE_JAVASCRIPT_DEBUGGER=1',
       'ENABLE_LEGACY_CSS_VENDOR_PREFIXES=0',
       'ENABLE_LEGACY_VIEWPORT_ADAPTION=1',
@@ -157,6 +156,7 @@
           'ENABLE_FAST_MOBILE_SCROLLING=1',
           'ENABLE_INPUT_SPEECH=0',
           'ENABLE_INPUT_TYPE_COLOR=0',
+          'ENABLE_INPUT_TYPE_WEEK=0',
           'ENABLE_JAVASCRIPT_I18N_API=0',
           'ENABLE_LEGACY_NOTIFICATIONS=0',
           'ENABLE_MEDIA_CAPTURE=1',
@@ -179,6 +179,7 @@
           'ENABLE_DATALIST_ELEMENT=1',
           'ENABLE_INPUT_SPEECH=1',
           'ENABLE_INPUT_TYPE_COLOR=1',
+          'ENABLE_INPUT_TYPE_WEEK=1',
           'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',
           'ENABLE_JAVASCRIPT_I18N_API=1',
           'ENABLE_LEGACY_NOTIFICATIONS=1',
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to