Title: [132590] trunk/Source/_javascript_Core
Revision
132590
Author
[email protected]
Date
2012-10-26 02:33:48 -0700 (Fri, 26 Oct 2012)

Log Message

[WIN] Make LLInt offsets extractor work on Windows
https://bugs.webkit.org/show_bug.cgi?id=100369

Patch by Simon Hausmann <[email protected]> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
it's a text mode file that needs even new line conversions. The binary mode parameter is
ignored on other platforms.

* offlineasm/offsets.rb:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (132589 => 132590)


--- trunk/Source/_javascript_Core/ChangeLog	2012-10-26 09:09:09 UTC (rev 132589)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-10-26 09:33:48 UTC (rev 132590)
@@ -1,3 +1,16 @@
+2012-10-26  Simon Hausmann  <[email protected]>
+
+        [WIN] Make LLInt offsets extractor work on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=100369
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
+        it's a text mode file that needs even new line conversions. The binary mode parameter is
+        ignored on other platforms.
+
+        * offlineasm/offsets.rb:
+
 2012-10-25  Michael Saboff  <[email protected]>
 
         SymbolTableIndexHashTraits::needsDestruction should be set to true

Modified: trunk/Source/_javascript_Core/offlineasm/offsets.rb (132589 => 132590)


--- trunk/Source/_javascript_Core/offlineasm/offsets.rb	2012-10-26 09:09:09 UTC (rev 132589)
+++ trunk/Source/_javascript_Core/offlineasm/offsets.rb	2012-10-26 09:33:48 UTC (rev 132590)
@@ -105,7 +105,7 @@
     
     fileBytes = []
     
-    File.open(file, "r") {
+    File.open(file, "rb") {
         | inp |
         loop {
             byte = inp.getbyte
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to