Title: [132687] trunk/Source/WebKit/blackberry
- Revision
- 132687
- Author
- [email protected]
- Date
- 2012-10-26 13:02:41 -0700 (Fri, 26 Oct 2012)
Log Message
[BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
https://bugs.webkit.org/show_bug.cgi?id=100421
Reviewed by Yong Li.
Patch by Jacky Jiang <[email protected]>.
PR: 231173
When leaving fullscreen, we need to suspend screen and backing store
updates before setting scroll position and changing transformation and
resume after they are done. In which way, we can get rid of a noticeable
glitch during the transition.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (132686 => 132687)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-26 19:58:01 UTC (rev 132686)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-10-26 20:02:41 UTC (rev 132687)
@@ -5971,6 +5971,8 @@
// The Browser chrome has its own fullscreen video widget.
exitFullscreenForNode(element);
} else {
+ m_backingStore->d->suspendScreenAndBackingStoreUpdates();
+
// When leaving fullscreen mode, we need to restore the 'x' scroll position
// before fullscreen.
// FIXME: We may need to respect 'y' position as well, because the web page always scrolls to
@@ -5989,6 +5991,9 @@
m_scaleBeforeFullScreen = -1.0;
}
+ notifyTransformChanged();
+ m_backingStore->d->resumeScreenAndBackingStoreUpdates(BackingStore::RenderAndBlit);
+
// This is where we would restore the browser's chrome
// if hidden above.
client()->fullscreenStop();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (132686 => 132687)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-10-26 19:58:01 UTC (rev 132686)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-10-26 20:02:41 UTC (rev 132687)
@@ -1,3 +1,19 @@
+2012-10-26 Jacky Jiang <[email protected]>
+
+ [BlackBerry][FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
+ https://bugs.webkit.org/show_bug.cgi?id=100421
+
+ Reviewed by Yong Li.
+
+ PR: 231173
+ When leaving fullscreen, we need to suspend screen and backing store
+ updates before setting scroll position and changing transformation and
+ resume after they are done. In which way, we can get rid of a noticeable
+ glitch during the transition.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
+
2012-10-26 Sean Wang <[email protected]>
[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
