Title: [132772] trunk/Source/WebCore
- Revision
- 132772
- Author
- [email protected]
- Date
- 2012-10-29 01:48:16 -0700 (Mon, 29 Oct 2012)
Log Message
Web Inspector: The bubble for repeated errors is misplaced.
https://bugs.webkit.org/show_bug.cgi?id=100525
Reviewed by Pavel Feldman.
The repeated-message bubble is displayed as an inline-block element,
which works well as long as no stack trace is present. If present, the
message is wrapped in an 'ol' element displayed as a block, which pushes
itself down to the next line.
To avoid that issue, this patch switches the wrapper element to flexbox,
glorious flexbox.
* inspector/front-end/inspector.css:
(.console-message .bubble):
(.repeated-message .outline-disclosure):
(.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132771 => 132772)
--- trunk/Source/WebCore/ChangeLog 2012-10-29 08:45:58 UTC (rev 132771)
+++ trunk/Source/WebCore/ChangeLog 2012-10-29 08:48:16 UTC (rev 132772)
@@ -1,3 +1,23 @@
+2012-10-29 Mike West <[email protected]>
+
+ Web Inspector: The bubble for repeated errors is misplaced.
+ https://bugs.webkit.org/show_bug.cgi?id=100525
+
+ Reviewed by Pavel Feldman.
+
+ The repeated-message bubble is displayed as an inline-block element,
+ which works well as long as no stack trace is present. If present, the
+ message is wrapped in an 'ol' element displayed as a block, which pushes
+ itself down to the next line.
+
+ To avoid that issue, this patch switches the wrapper element to flexbox,
+ glorious flexbox.
+
+ * inspector/front-end/inspector.css:
+ (.console-message .bubble):
+ (.repeated-message .outline-disclosure):
+ (.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message):
+
2012-10-29 Alexander Pavlov <[email protected]>
Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (132771 => 132772)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-10-29 08:45:58 UTC (rev 132771)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-10-29 08:48:16 UTC (rev 132772)
@@ -924,7 +924,7 @@
vertical-align: middle;
white-space: nowrap;
padding: 1px 4px;
- margin-top: -2px;
+ margin-top: -1px;
margin-right: 4px;
margin-left: -18px;
text-align: left;
@@ -945,6 +945,10 @@
visibility: hidden;
}
+.repeated-message .outline-disclosure {
+ -webkit-flex: 1;
+}
+
.console-group .console-group > .console-group-messages {
margin-left: 16px;
}
@@ -1988,6 +1992,12 @@
display: block;
}
+.filter-all .console-warning-level.repeated-message, .filter-warnings .console-warning-level.repeated-message,
+.filter-all .console-error-level.repeated-message, .filter-errors .console-error-level.repeated-message,
+.filter-all .console-log-level.repeated-message, .filter-logs .console-log-level.repeated-message {
+ display: -webkit-flex;
+}
+
.console-user-command-result {
display: block;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
