Title: [132797] trunk/Source/WebCore
- Revision
- 132797
- Author
- [email protected]
- Date
- 2012-10-29 07:23:44 -0700 (Mon, 29 Oct 2012)
Log Message
Web Inspector: Toolbar overflow appears outside window
https://bugs.webkit.org/show_bug.cgi?id=100663
Patch by Patrick Dubroy <[email protected]> on 2012-10-29
Reviewed by Pavel Feldman.
Since the search bar was removed from the toolbar, the overflow menu appears too far
to the right, and is unreadable. Fixed this by aligning it relative to the right side
of the window, rather than the left.
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/inspector.css:
(#toolbar-dropdown .toolbar-label):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132796 => 132797)
--- trunk/Source/WebCore/ChangeLog 2012-10-29 14:23:07 UTC (rev 132796)
+++ trunk/Source/WebCore/ChangeLog 2012-10-29 14:23:44 UTC (rev 132797)
@@ -1,3 +1,19 @@
+2012-10-29 Patrick Dubroy <[email protected]>
+
+ Web Inspector: Toolbar overflow appears outside window
+ https://bugs.webkit.org/show_bug.cgi?id=100663
+
+ Reviewed by Pavel Feldman.
+
+ Since the search bar was removed from the toolbar, the overflow menu appears too far
+ to the right, and is unreadable. Fixed this by aligning it relative to the right side
+ of the window, rather than the left.
+
+ * inspector/front-end/Toolbar.js:
+ (WebInspector.ToolbarDropdown.prototype.show):
+ * inspector/front-end/inspector.css:
+ (#toolbar-dropdown .toolbar-label):
+
2012-10-29 Michelangelo De Simone <[email protected]>
[CSS Shaders] Implement CustomFilterArrayParameter::blend
Modified: trunk/Source/WebCore/inspector/front-end/Toolbar.js (132796 => 132797)
--- trunk/Source/WebCore/inspector/front-end/Toolbar.js 2012-10-29 14:23:07 UTC (rev 132796)
+++ trunk/Source/WebCore/inspector/front-end/Toolbar.js 2012-10-29 14:23:44 UTC (rev 132797)
@@ -216,7 +216,7 @@
var top = this._arrow.totalOffsetTop() + this._arrow.clientHeight;
this._arrow.addStyleClass("dropdown-visible");
this.element.style.top = top + "px";
- this.element.style.left = this._arrow.totalOffsetLeft() + "px";
+ this.element.style.right = window.innerWidth - this._arrow.totalOffsetLeft() - this._arrow.clientWidth + "px";
this._contentElement.style.maxHeight = window.innerHeight - top - 20 + "px";
this._toolbar.element.appendChild(this.element);
},
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (132796 => 132797)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-10-29 14:23:07 UTC (rev 132796)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-10-29 14:23:44 UTC (rev 132797)
@@ -245,6 +245,11 @@
margin-right: 0.5em;
}
+#toolbar-dropdown .toolbar-label {
+ line-height: 32px;
+ top: 0;
+}
+
.scrollable-content {
position: static;
height: 100%;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
