Title: [132814] branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp
- Revision
- 132814
- Author
- [email protected]
- Date
- 2012-10-29 10:28:43 -0700 (Mon, 29 Oct 2012)
Log Message
Merge 132287 - Crash in WebCore::SubresourceLoader::willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=100147
Reviewed by Abhishek Arya.
No new tests. There is a test case that should cover this, but it doesn't
work correctly on many platforms due to its use of testRunner.addURLToRedirect().
See http/tests/loading/cross-origin-XHR-willLoadRequest.html.
Tested manually on http://www.nick.co.uk/shows/spongebob
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
[email protected]
Review URL: https://codereview.chromium.org/11312006
Modified Paths
Diff
Modified: branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp (132813 => 132814)
--- branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp 2012-10-29 17:26:59 UTC (rev 132813)
+++ branches/chromium/1271/Source/WebCore/loader/SubresourceLoader.cpp 2012-10-29 17:28:43 UTC (rev 132814)
@@ -164,6 +164,7 @@
{
// Store the previous URL because the call to ResourceLoader::willSendRequest will modify it.
KURL previousURL = request().url();
+ RefPtr<SubresourceLoader> protect(this);
ResourceLoader::willSendRequest(newRequest, redirectResponse);
if (!previousURL.isNull() && !newRequest.isNull() && previousURL != newRequest.url()) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
