Title: [132976] trunk/Source/WebCore
- Revision
- 132976
- Author
- [email protected]
- Date
- 2012-10-30 19:01:58 -0700 (Tue, 30 Oct 2012)
Log Message
[BlackBerry] PurgeCredential should also purge the persisted credential store
https://bugs.webkit.org/show_bug.cgi?id=100744
Reviewed by George Staikos.
When challenged by the server, we will check the credential in-memory and from the persistent storage.
So the invalid credentials should also be purged from the persistent credential storage; Otherwise,
it will be sent to the server next time been challenged, instead of prompting the user.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::purgeCredentials):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132975 => 132976)
--- trunk/Source/WebCore/ChangeLog 2012-10-31 02:01:51 UTC (rev 132975)
+++ trunk/Source/WebCore/ChangeLog 2012-10-31 02:01:58 UTC (rev 132976)
@@ -1,3 +1,17 @@
+2012-10-30 Charles Wei <[email protected]>
+
+ [BlackBerry] PurgeCredential should also purge the persisted credential store
+ https://bugs.webkit.org/show_bug.cgi?id=100744
+
+ Reviewed by George Staikos.
+
+ When challenged by the server, we will check the credential in-memory and from the persistent storage.
+ So the invalid credentials should also be purged from the persistent credential storage; Otherwise,
+ it will be sent to the server next time been challenged, instead of prompting the user.
+
+ * platform/network/blackberry/NetworkJob.cpp:
+ (WebCore::NetworkJob::purgeCredentials):
+
2012-10-30 Allan Sandfeld Jensen <[email protected]>
DOM URL is flaky when workers are used
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (132975 => 132976)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-10-31 02:01:51 UTC (rev 132975)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-10-31 02:01:58 UTC (rev 132976)
@@ -23,6 +23,7 @@
#include "Chrome.h"
#include "ChromeClient.h"
#include "CookieManager.h"
+#include "CredentialBackingStore.h"
#include "CredentialStorage.h"
#include "Frame.h"
#include "FrameLoaderClientBlackBerry.h"
@@ -874,6 +875,9 @@
CredentialStorage::remove(challenge.protectionSpace());
challenge.setStored(false);
+#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
+ credentialBackingStore().removeLogin(m_response.url(), challenge.protectionSpace());
+#endif
}
bool NetworkJob::shouldSendClientData() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
