Title: [133009] trunk/Source/WebKit/chromium
- Revision
- 133009
- Author
- [email protected]
- Date
- 2012-10-31 04:26:08 -0700 (Wed, 31 Oct 2012)
Log Message
Remove code to hide/reshow text caret for PagePopups
https://bugs.webkit.org/show_bug.cgi?id=100834
Reviewed by Hajime Morita.
All of form controls supporting PagePopups don't have a text
caret. We don't need to hide a text caret on opening a PagePopup,
and don't need to reshow it on closing the PagePopup.
We had this code because an old UI of input[type=date] had a text
caret.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup):
(WebKit::WebViewImpl::closePagePopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (133008 => 133009)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-31 11:03:20 UTC (rev 133008)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-31 11:26:08 UTC (rev 133009)
@@ -1,3 +1,21 @@
+2012-10-31 Kent Tamura <[email protected]>
+
+ Remove code to hide/reshow text caret for PagePopups
+ https://bugs.webkit.org/show_bug.cgi?id=100834
+
+ Reviewed by Hajime Morita.
+
+ All of form controls supporting PagePopups don't have a text
+ caret. We don't need to hide a text caret on opening a PagePopup,
+ and don't need to reshow it on closing the PagePopup.
+
+ We had this code because an old UI of input[type=date] had a text
+ caret.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::openPagePopup):
+ (WebKit::WebViewImpl::closePagePopup):
+
2012-10-31 Mike West <[email protected]>
Script run from an isolated world should bypass a page's CSP.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (133008 => 133009)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-10-31 11:03:20 UTC (rev 133008)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-10-31 11:26:08 UTC (rev 133009)
@@ -1436,9 +1436,6 @@
m_pagePopup->closePopup();
m_pagePopup = 0;
}
-
- if (Frame* frame = focusedWebCoreFrame())
- frame->selection()->setCaretVisible(false);
return m_pagePopup.get();
}
@@ -1451,9 +1448,6 @@
return;
m_pagePopup->closePopup();
m_pagePopup = 0;
-
- if (Frame* frame = focusedWebCoreFrame())
- frame->selection()->pageActivationChanged();
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
