Title: [133069] trunk
Revision
133069
Author
[email protected]
Date
2012-10-31 13:35:04 -0700 (Wed, 31 Oct 2012)

Log Message

[chromium] DRT and WTR should clear the cache between tests
https://bugs.webkit.org/show_bug.cgi?id=93195

Reviewed by Tony Chang.

Tools:

This change makes chromium DRT match the GTK+, Qt, and EFL ports.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.

LayoutTests:

* media/video-poster-blocked-by-willsendrequest.html: updated list of still-busted ports.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (133068 => 133069)


--- trunk/LayoutTests/ChangeLog	2012-10-31 20:11:53 UTC (rev 133068)
+++ trunk/LayoutTests/ChangeLog	2012-10-31 20:35:04 UTC (rev 133069)
@@ -1,3 +1,12 @@
+2012-10-31  Ami Fischman  <[email protected]>
+
+        [chromium] DRT and WTR should clear the cache between tests
+        https://bugs.webkit.org/show_bug.cgi?id=93195
+
+        Reviewed by Tony Chang.
+
+        * media/video-poster-blocked-by-willsendrequest.html: updated list of still-busted ports.
+
 2012-10-31  Stephen White  <[email protected]>
 
         [Chromium] Unreviewed gardening.  Mark a few tests as crashing.

Modified: trunk/LayoutTests/media/video-poster-blocked-by-willsendrequest.html (133068 => 133069)


--- trunk/LayoutTests/media/video-poster-blocked-by-willsendrequest.html	2012-10-31 20:11:53 UTC (rev 133068)
+++ trunk/LayoutTests/media/video-poster-blocked-by-willsendrequest.html	2012-10-31 20:35:04 UTC (rev 133069)
@@ -37,7 +37,7 @@
                 testExpected("video.clientWidth", 300);
                 testExpected("video.clientHeight", 150);
 
-                // FIXME: the getTime() below works around a bug in DRT where caches aren't cleared between tests; chromium: 93195, mac: 82976, gtk: 79760.
+                // FIXME: the getTime() below works around a bug (82976) in mac DRT where caches aren't cleared between tests.
                 video.poster = "content/abe.png?" + (new Date().getTime());
 
                 setTimeout(testAfterLoadingPoster, 100);

Modified: trunk/Tools/ChangeLog (133068 => 133069)


--- trunk/Tools/ChangeLog	2012-10-31 20:11:53 UTC (rev 133068)
+++ trunk/Tools/ChangeLog	2012-10-31 20:35:04 UTC (rev 133069)
@@ -1,3 +1,15 @@
+2012-10-31  Ami Fischman  <[email protected]>
+
+        [chromium] DRT and WTR should clear the cache between tests
+        https://bugs.webkit.org/show_bug.cgi?id=93195
+
+        Reviewed by Tony Chang.
+
+        This change makes chromium DRT match the GTK+, Qt, and EFL ports.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.
+
 2012-10-31  Dirk Pranke  <[email protected]>
 
         Fix typos introduced in r133061.

Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (133068 => 133069)


--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2012-10-31 20:11:53 UTC (rev 133068)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2012-10-31 20:35:04 UTC (rev 133069)
@@ -35,6 +35,7 @@
 #include "DRTDevToolsClient.h"
 #include "DRTTestRunner.h"
 #include "MockWebPrerenderingSupport.h"
+#include "WebCache.h"
 #include "WebDataSource.h"
 #include "WebDocument.h"
 #include "WebElement.h"
@@ -318,6 +319,7 @@
     webView()->setFixedLayoutSize(WebSize(0, 0));
     webView()->mainFrame()->clearOpener();
     WebTestingSupport::resetInternalsObject(webView()->mainFrame());
+    WebCache::clear();
 }
 
 void TestShell::loadURL(const WebURL& url)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to