Title: [133102] trunk/Source/WebKit/blackberry
- Revision
- 133102
- Author
- [email protected]
- Date
- 2012-10-31 17:59:13 -0700 (Wed, 31 Oct 2012)
Log Message
[BlackBerry] Crash on html popup form control when element is deleted
https://bugs.webkit.org/show_bug.cgi?id=100869
Reviewed by Yong Li.
Make the element pointers RefPtr so they don't go away before the popup
is closed.
* WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
* WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
* WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (133101 => 133102)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-01 00:39:39 UTC (rev 133101)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-01 00:59:13 UTC (rev 133102)
@@ -1,3 +1,20 @@
+2012-10-31 George Staikos <[email protected]>
+
+ [BlackBerry] Crash on html popup form control when element is deleted
+ https://bugs.webkit.org/show_bug.cgi?id=100869
+
+ Reviewed by Yong Li.
+
+ Make the element pointers RefPtr so they don't go away before the popup
+ is closed.
+
+ * WebCoreSupport/ColorPickerClient.h:
+ (ColorPickerClient):
+ * WebCoreSupport/DatePickerClient.h:
+ (DatePickerClient):
+ * WebCoreSupport/SelectPopupClient.h:
+ (SelectPopupClient):
+
2012-10-31 Genevieve Mak <[email protected]>
[BLACKBERRY] Custom WebWorks context menus don't always work.
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h (133101 => 133102)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h 2012-11-01 00:39:39 UTC (rev 133101)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h 2012-11-01 00:59:13 UTC (rev 133102)
@@ -53,7 +53,7 @@
String m_source;
BlackBerry::WebKit::WebPagePrivate* m_webPage;
- HTMLInputElement* m_element;
+ RefPtr<HTMLInputElement> m_element;
};
} // namespace WebCore
#endif
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h (133101 => 133102)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h 2012-11-01 00:39:39 UTC (rev 133101)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h 2012-11-01 00:59:13 UTC (rev 133102)
@@ -55,7 +55,7 @@
BlackBerry::Platform::BlackBerryInputType m_type;
String m_source;
BlackBerry::WebKit::WebPagePrivate* m_webPage;
- HTMLInputElement* m_element;
+ RefPtr<HTMLInputElement> m_element;
};
} // namespace WebCore
#endif
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h (133101 => 133102)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h 2012-11-01 00:39:39 UTC (rev 133101)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h 2012-11-01 00:59:13 UTC (rev 133102)
@@ -62,7 +62,7 @@
unsigned m_size;
String m_source;
BlackBerry::WebKit::WebPagePrivate* m_webPage;
- HTMLSelectElement* m_element;
+ RefPtr<HTMLSelectElement> m_element;
WebCore::Timer<SelectPopupClient> m_notifyChangeTimer;
};
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
