Title: [133359] trunk/Source/_javascript_Core
- Revision
- 133359
- Author
- [email protected]
- Date
- 2012-11-02 15:21:34 -0700 (Fri, 02 Nov 2012)
Log Message
JIT::privateCompileGetByVal should use the uint8ClampedArrayDescriptor for compiling accesses to Uint8ClampedArrays
https://bugs.webkit.org/show_bug.cgi?id=101112
Reviewed by Gavin Barraclough.
The only reason why the code was wrong to use uint8ArrayDescriptor instead is that if we're just using
Uint8ClampedArrays then the descriptor for Uint8Array may not have been initialized.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (133358 => 133359)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-02 22:14:28 UTC (rev 133358)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-02 22:21:34 UTC (rev 133359)
@@ -1,3 +1,16 @@
+2012-11-02 Filip Pizlo <[email protected]>
+
+ JIT::privateCompileGetByVal should use the uint8ClampedArrayDescriptor for compiling accesses to Uint8ClampedArrays
+ https://bugs.webkit.org/show_bug.cgi?id=101112
+
+ Reviewed by Gavin Barraclough.
+
+ The only reason why the code was wrong to use uint8ArrayDescriptor instead is that if we're just using
+ Uint8ClampedArrays then the descriptor for Uint8Array may not have been initialized.
+
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::privateCompileGetByVal):
+
2012-11-02 Mark Hahnenberg <[email protected]>
MarkedBlocks should use something other than the mark bits to indicate liveness for newly allocated objects
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (133358 => 133359)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2012-11-02 22:14:28 UTC (rev 133358)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2012-11-02 22:21:34 UTC (rev 133359)
@@ -1381,9 +1381,11 @@
slowCases = emitIntTypedArrayGetByVal(currentInstruction, badType, m_globalData->int32ArrayDescriptor(), 4, SignedTypedArray);
break;
case JITUint8Array:
- case JITUint8ClampedArray:
slowCases = emitIntTypedArrayGetByVal(currentInstruction, badType, m_globalData->uint8ArrayDescriptor(), 1, UnsignedTypedArray);
break;
+ case JITUint8ClampedArray:
+ slowCases = emitIntTypedArrayGetByVal(currentInstruction, badType, m_globalData->uint8ClampedArrayDescriptor(), 1, UnsignedTypedArray);
+ break;
case JITUint16Array:
slowCases = emitIntTypedArrayGetByVal(currentInstruction, badType, m_globalData->uint16ArrayDescriptor(), 2, UnsignedTypedArray);
break;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
