Title: [133420] trunk
- Revision
- 133420
- Author
- [email protected]
- Date
- 2012-11-04 05:26:58 -0800 (Sun, 04 Nov 2012)
Log Message
Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080
Reviewed by Dirk Schulze.
Source/WebCore:
CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
unimplemented property assert. Adding a stub entry to avoid that.
Test: svg/css/color-profile-crash.html
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
LayoutTests:
* svg/css/color-profile-crash-expected.txt: Added.
* svg/css/color-profile-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (133419 => 133420)
--- trunk/LayoutTests/ChangeLog 2012-11-04 12:30:46 UTC (rev 133419)
+++ trunk/LayoutTests/ChangeLog 2012-11-04 13:26:58 UTC (rev 133420)
@@ -1,3 +1,13 @@
+2012-11-04 Florin Malita <[email protected]>
+
+ Color-profile property triggers assert
+ https://bugs.webkit.org/show_bug.cgi?id=101080
+
+ Reviewed by Dirk Schulze.
+
+ * svg/css/color-profile-crash-expected.txt: Added.
+ * svg/css/color-profile-crash.html: Added.
+
2012-11-04 Csaba Osztrogonác <[email protected]>
[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.
Added: trunk/LayoutTests/svg/css/color-profile-crash-expected.txt (0 => 133420)
--- trunk/LayoutTests/svg/css/color-profile-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/css/color-profile-crash-expected.txt 2012-11-04 13:26:58 UTC (rev 133420)
@@ -0,0 +1 @@
+PASS: did not crash.
Added: trunk/LayoutTests/svg/css/color-profile-crash.html (0 => 133420)
--- trunk/LayoutTests/svg/css/color-profile-crash.html (rev 0)
+++ trunk/LayoutTests/svg/css/color-profile-crash.html 2012-11-04 13:26:58 UTC (rev 133420)
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+ <body>
+ <div style="color-profile: sRGB;">PASS: did not crash.</div>
+
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ </script>
+ </body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (133419 => 133420)
--- trunk/Source/WebCore/ChangeLog 2012-11-04 12:30:46 UTC (rev 133419)
+++ trunk/Source/WebCore/ChangeLog 2012-11-04 13:26:58 UTC (rev 133420)
@@ -1,3 +1,18 @@
+2012-11-04 Florin Malita <[email protected]>
+
+ Color-profile property triggers assert
+ https://bugs.webkit.org/show_bug.cgi?id=101080
+
+ Reviewed by Dirk Schulze.
+
+ CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
+ unimplemented property assert. Adding a stub entry to avoid that.
+
+ Test: svg/css/color-profile-crash.html
+
+ * css/SVGCSSStyleSelector.cpp:
+ (WebCore::StyleResolver::applySVGProperty):
+
2012-11-04 Kaustubh Atrawalkar <[email protected]>
Unable to copy text on disabled input fields on long press gesture
Modified: trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp (133419 => 133420)
--- trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp 2012-11-04 12:30:46 UTC (rev 133419)
+++ trunk/Source/WebCore/css/SVGCSSStyleSelector.cpp 2012-11-04 13:26:58 UTC (rev 133420)
@@ -185,6 +185,11 @@
svgstyle->setColorInterpolationFilters(*primitiveValue);
break;
}
+ case CSSPropertyColorProfile:
+ {
+ // Not implemented.
+ break;
+ }
case CSSPropertyColorRendering:
{
HANDLE_INHERIT_AND_INITIAL(colorRendering, ColorRendering)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
