Title: [133515] trunk/Source/WebKit/blackberry
- Revision
- 133515
- Author
- [email protected]
- Date
- 2012-11-05 12:40:13 -0800 (Mon, 05 Nov 2012)
Log Message
[BlackBerry] Input date should not popup dialog when readonly is set
https://bugs.webkit.org/show_bug.cgi?id=101234
Reviewed by Yong Li.
PR 236114
Reviewed internally by Mike Fenton.
Suppress popup dialog if the input element has readonly attribute set.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::openColorPopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (133514 => 133515)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-05 20:36:31 UTC (rev 133514)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-05 20:40:13 UTC (rev 133515)
@@ -1,3 +1,20 @@
+2012-11-05 Rob Buis <[email protected]>
+
+ [BlackBerry] Input date should not popup dialog when readonly is set
+ https://bugs.webkit.org/show_bug.cgi?id=101234
+
+ Reviewed by Yong Li.
+
+ PR 236114
+
+ Reviewed internally by Mike Fenton.
+
+ Suppress popup dialog if the input element has readonly attribute set.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::openDatePopup):
+ (BlackBerry::WebKit::InputHandler::openColorPopup):
+
2012-11-05 Genevieve Mak <[email protected]>
[BLACKBERRY] Update touch code to reflect touch refactor
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (133514 => 133515)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-05 20:36:31 UTC (rev 133514)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-05 20:40:13 UTC (rev 133515)
@@ -962,7 +962,7 @@
bool InputHandler::openDatePopup(HTMLInputElement* element, BlackBerryInputType type)
{
- if (!element || element->disabled() || !DOMSupport::isDateTimeInputField(element))
+ if (!element || element->disabled() || element->readOnly() || !DOMSupport::isDateTimeInputField(element))
return false;
if (isActiveTextEdit())
@@ -991,7 +991,7 @@
bool InputHandler::openColorPopup(HTMLInputElement* element)
{
- if (!element || element->disabled() || !DOMSupport::isColorInputField(element))
+ if (!element || element->disabled() || element->readOnly() || !DOMSupport::isColorInputField(element))
return false;
if (isActiveTextEdit())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
