Diff
Modified: trunk/LayoutTests/ChangeLog (133526 => 133527)
--- trunk/LayoutTests/ChangeLog 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/ChangeLog 2012-11-05 22:32:07 UTC (rev 133527)
@@ -1,3 +1,20 @@
+2012-11-05 Adam Barth <[email protected]>
+
+ webkitRegionLayoutUpdate is incorrectly named
+ https://bugs.webkit.org/show_bug.cgi?id=100335
+
+ Reviewed by Ojan Vafai.
+
+ Update tests to use the proper name.
+
+ * fast/regions/webkit-named-flow-event-add-to-flow.html:
+ * fast/regions/webkit-named-flow-event-no-regions.html:
+ * fast/regions/webkit-named-flow-event-remove-from-dom.html:
+ * fast/regions/webkit-named-flow-event-remove-from-flow.html:
+ * fast/regions/webkit-named-flow-event-target.html:
+ * fast/regions/webkit-named-flow-event-to-null.html:
+ * fast/regions/webkit-named-flow-event.html:
+
2012-11-05 Stephen White <[email protected]>
Remove fast/forms/week-multiple-fields from
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -50,7 +50,7 @@
shouldBeEqualToString("event.target.name", "article");
if (++count > 1) {
- event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
// this should be reached after region_2 is added to flow
finishJSTest();
@@ -62,7 +62,7 @@
function startTest() {
var flow = getFlowByName("article");
- flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
debug("Flow content");
flowContent("region_1", "article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -53,7 +53,7 @@
function regionLayoutUpdated(event) {
shouldBeEqualToString("event.target.name", "article");
if (++count > 1) {
- event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
finishJSTest();
return;
}
@@ -68,7 +68,7 @@
function startTest() {
var flow = getFlowByName("article");
- flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -54,7 +54,7 @@
function regionLayoutUpdated(event) {
shouldBeEqualToString("event.target.name", "article");
if (++count > 1) {
- event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
// this should be reached after region_2 is removed from DOM
finishJSTest();
return;
@@ -67,7 +67,7 @@
function startTest() {
var flow = getFlowByName("article");
- flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -52,7 +52,7 @@
function regionLayoutUpdated(event) {
shouldBeEqualToString("event.target.name", "article");
if (++count > 1) {
- event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
// this should be reached after region_2 is removed from DOM
finishJSTest();
return;
@@ -65,7 +65,7 @@
function startTest() {
var flow = getFlowByName("article");
- flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-target.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-target.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-target.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -83,7 +83,7 @@
if (updatedCount == 2) {
shouldBeTrue("recreated");
- event.target.removeEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", flowThreadUpdated);
makeFlowNull();
finishJSTest();
return;
@@ -98,7 +98,7 @@
function startTest() {
var flowThread = getFlowByName("article");
- flowThread.addEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+ flowThread.addEventListener("webkitregionlayoutupdate", flowThreadUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event-to-null.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event-to-null.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event-to-null.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -56,7 +56,7 @@
function regionLayoutUpdated(event) {
shouldBeEqualToString("event.target.name", "article");
if (++count > 1) {
- event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
layoutUpdateDispatchedForNullFlow = true;
return;
}
@@ -81,7 +81,7 @@
function startTest() {
var flow = getFlowByName("article");
- flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+ flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-event.html (133526 => 133527)
--- trunk/LayoutTests/fast/regions/webkit-named-flow-event.html 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/LayoutTests/fast/regions/webkit-named-flow-event.html 2012-11-05 22:32:07 UTC (rev 133527)
@@ -49,14 +49,14 @@
function flowThreadUpdated(event) {
shouldBeEqualToString("event.target.name", "article");
- event.target.removeEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+ event.target.removeEventListener("webkitregionlayoutupdate", flowThreadUpdated);
finishJSTest();
}
function startTest() {
var flowThread = getFlowByName("article");
- flowThread.addEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+ flowThread.addEventListener("webkitregionlayoutupdate", flowThreadUpdated);
debug("Flow content");
flowContent("article");
Modified: trunk/Source/WebCore/ChangeLog (133526 => 133527)
--- trunk/Source/WebCore/ChangeLog 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/Source/WebCore/ChangeLog 2012-11-05 22:32:07 UTC (rev 133527)
@@ -1,5 +1,19 @@
2012-11-05 Adam Barth <[email protected]>
+ webkitRegionLayoutUpdate is incorrectly named
+ https://bugs.webkit.org/show_bug.cgi?id=100335
+
+ Reviewed by Ojan Vafai.
+
+ DOM event names are supposed to be lower case.
+
+ * dom/EventNames.h:
+ (WebCore):
+ * dom/WebKitNamedFlow.cpp:
+ (WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
+
+2012-11-05 Adam Barth <[email protected]>
+
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Modified: trunk/Source/WebCore/dom/EventNames.h (133526 => 133527)
--- trunk/Source/WebCore/dom/EventNames.h 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/Source/WebCore/dom/EventNames.h 2012-11-05 22:32:07 UTC (rev 133527)
@@ -235,7 +235,7 @@
macro(webkitpointerlockchange) \
macro(webkitpointerlockerror) \
\
- macro(webkitRegionLayoutUpdate) \
+ macro(webkitregionlayoutupdate) \
\
macro(webkitnetworkinfochange) \
\
Modified: trunk/Source/WebCore/dom/WebKitNamedFlow.cpp (133526 => 133527)
--- trunk/Source/WebCore/dom/WebKitNamedFlow.cpp 2012-11-05 22:15:50 UTC (rev 133526)
+++ trunk/Source/WebCore/dom/WebKitNamedFlow.cpp 2012-11-05 22:32:07 UTC (rev 133527)
@@ -198,7 +198,7 @@
ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
ASSERT(m_parentFlowThread);
- RefPtr<Event> event = UIEvent::create(eventNames().webkitRegionLayoutUpdateEvent, false, false, m_parentFlowThread->document()->defaultView(), 0);
+ RefPtr<Event> event = UIEvent::create(eventNames().webkitregionlayoutupdateEvent, false, false, m_parentFlowThread->document()->defaultView(), 0);
dispatchEvent(event);
}
