Title: [133533] trunk
Revision
133533
Author
[email protected]
Date
2012-11-05 15:10:07 -0800 (Mon, 05 Nov 2012)

Log Message

Back out controversial changes from Bug 98665.
https://bugs.webkit.org/show_bug.cgi?id=101244

Patch by Dima Gorbik <[email protected]> on 2012-11-05
Reviewed by David Kilzer.

Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.

Source/_javascript_Core:

* API/tests/minidom.c:
* API/tests/testapi.c:

Source/WTF:

* wtf/Assertions.h:

Tools:

* DumpRenderTree/mac/MockGeolocationProvider.mm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/tests/minidom.c (133532 => 133533)


--- trunk/Source/_javascript_Core/API/tests/minidom.c	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Source/_javascript_Core/API/tests/minidom.c	2012-11-05 23:10:07 UTC (rev 133533)
@@ -30,7 +30,6 @@
 #include "JSStringRef.h"
 #include <stdio.h>
 #include <stdlib.h>
-#include <wtf/Platform.h>
 #include <wtf/Assertions.h>
 #include <wtf/UnusedParam.h>
 

Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (133532 => 133533)


--- trunk/Source/_javascript_Core/API/tests/testapi.c	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c	2012-11-05 23:10:07 UTC (rev 133533)
@@ -29,7 +29,6 @@
 #include "JSObjectRefPrivate.h"
 #include <math.h>
 #define ASSERT_DISABLED 0
-#include <wtf/Platform.h>
 #include <wtf/Assertions.h>
 #include <wtf/UnusedParam.h>
 

Modified: trunk/Source/_javascript_Core/ChangeLog (133532 => 133533)


--- trunk/Source/_javascript_Core/ChangeLog	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-11-05 23:10:07 UTC (rev 133533)
@@ -1,3 +1,15 @@
+2012-11-05  Dima Gorbik  <[email protected]>
+
+        Back out controversial changes from Bug 98665.
+        https://bugs.webkit.org/show_bug.cgi?id=101244
+
+        Reviewed by David Kilzer.
+
+        Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
+
+        * API/tests/minidom.c:
+        * API/tests/testapi.c:
+
 2012-11-04  Filip Pizlo  <[email protected]>
 
         Reduce the verbosity of referring to QNaN in _javascript_Core

Modified: trunk/Source/WTF/ChangeLog (133532 => 133533)


--- trunk/Source/WTF/ChangeLog	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Source/WTF/ChangeLog	2012-11-05 23:10:07 UTC (rev 133533)
@@ -1,3 +1,14 @@
+2012-11-05  Dima Gorbik  <[email protected]>
+
+        Back out controversial changes from Bug 98665.
+        https://bugs.webkit.org/show_bug.cgi?id=101244
+
+        Reviewed by David Kilzer.
+
+        Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
+
+        * wtf/Assertions.h:
+
 2012-11-03  Alexey Proskuryakov  <[email protected]>
 
         Get rid of USE(CFURLSTORAGESESSIONS)

Modified: trunk/Source/WTF/wtf/Assertions.h (133532 => 133533)


--- trunk/Source/WTF/wtf/Assertions.h	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Source/WTF/wtf/Assertions.h	2012-11-05 23:10:07 UTC (rev 133533)
@@ -42,6 +42,8 @@
    http://msdn2.microsoft.com/en-us/library/ms177415(VS.80).aspx
 */
 
+#include <wtf/Platform.h>
+
 #include <stddef.h>
 
 #if !COMPILER(MSVC)

Modified: trunk/Tools/ChangeLog (133532 => 133533)


--- trunk/Tools/ChangeLog	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Tools/ChangeLog	2012-11-05 23:10:07 UTC (rev 133533)
@@ -1,3 +1,14 @@
+2012-11-05  Dima Gorbik  <[email protected]>
+
+        Back out controversial changes from Bug 98665.
+        https://bugs.webkit.org/show_bug.cgi?id=101244
+
+        Reviewed by David Kilzer.
+
+        Backing out changes from Bug 98665 until further discussions take place on rules for including Platform.h in Assertions.h.
+
+        * DumpRenderTree/mac/MockGeolocationProvider.mm:
+
 2012-11-05  Dirk Pranke  <[email protected]>
 
         webkitpy: lint, clean up rebaseline.py

Modified: trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm (133532 => 133533)


--- trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm	2012-11-05 23:07:32 UTC (rev 133532)
+++ trunk/Tools/DumpRenderTree/mac/MockGeolocationProvider.mm	2012-11-05 23:10:07 UTC (rev 133533)
@@ -23,7 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
-#include <wtf/Platform.h>
+#import "config.h"
 #import "MockGeolocationProvider.h"
 
 @implementation MockGeolocationProvider
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to