Title: [133593] trunk/Source/WebCore
- Revision
- 133593
- Author
- [email protected]
- Date
- 2012-11-06 06:05:45 -0800 (Tue, 06 Nov 2012)
Log Message
Web Inspector: report physical memory really committed for JS heap in NMI
https://bugs.webkit.org/show_bug.cgi?id=101335
Some OSes (e.g. Linux) perform lazy commits of requested memory.
Because of that the committed memory may not retain any physical
memory until the very first access to the committed chunk.
That led to JS heap reported more physical memory than was currently
in use.
Patch by Alexei Filippov <[email protected]> on 2012-11-06
Reviewed by Vsevolod Vlasov.
* bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133592 => 133593)
--- trunk/Source/WebCore/ChangeLog 2012-11-06 13:57:59 UTC (rev 133592)
+++ trunk/Source/WebCore/ChangeLog 2012-11-06 14:05:45 UTC (rev 133593)
@@ -1,3 +1,19 @@
+2012-11-06 Alexei Filippov <[email protected]>
+
+ Web Inspector: report physical memory really committed for JS heap in NMI
+ https://bugs.webkit.org/show_bug.cgi?id=101335
+
+ Some OSes (e.g. Linux) perform lazy commits of requested memory.
+ Because of that the committed memory may not retain any physical
+ memory until the very first access to the committed chunk.
+ That led to JS heap reported more physical memory than was currently
+ in use.
+
+ Reviewed by Vsevolod Vlasov.
+
+ * bindings/v8/ScriptGCEvent.cpp:
+ (WebCore::ScriptGCEvent::getHeapSize):
+
2012-11-06 Vsevolod Vlasov <[email protected]>
Web Inspector: Breakpoint is not removed when it was set in non-formatted mode and then removed while in formatted mode.
Modified: trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp (133592 => 133593)
--- trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp 2012-11-06 13:57:59 UTC (rev 133592)
+++ trunk/Source/WebCore/bindings/v8/ScriptGCEvent.cpp 2012-11-06 14:05:45 UTC (rev 133593)
@@ -76,7 +76,7 @@
v8::HeapStatistics heapStatistics;
v8::V8::GetHeapStatistics(&heapStatistics);
info.usedJSHeapSize = heapStatistics.used_heap_size();
- info.totalJSHeapSize = heapStatistics.total_heap_size();
+ info.totalJSHeapSize = heapStatistics.total_physical_size();
info.jsHeapSizeLimit = heapStatistics.heap_size_limit();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
