Title: [133743] branches/chromium/1312/Source/WebKit/chromium
- Revision
- 133743
- Author
- [email protected]
- Date
- 2012-11-07 05:42:44 -0800 (Wed, 07 Nov 2012)
Log Message
Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830
Reviewed by Kent Tamura.
We need to account for the scroll position when calculating the root view rectangle in the screen.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
[email protected]
Review URL: https://codereview.chromium.org/11275190
Modified Paths
Diff
Modified: branches/chromium/1312/Source/WebKit/chromium/ChangeLog (133742 => 133743)
--- branches/chromium/1312/Source/WebKit/chromium/ChangeLog 2012-11-07 13:35:35 UTC (rev 133742)
+++ branches/chromium/1312/Source/WebKit/chromium/ChangeLog 2012-11-07 13:42:44 UTC (rev 133743)
@@ -1,3 +1,15 @@
+2012-10-31 Keishi Hattori <[email protected]>
+
+ [Chromium] Page popup shows up at wrong locations when root view is scrolled
+ https://bugs.webkit.org/show_bug.cgi?id=100830
+
+ Reviewed by Kent Tamura.
+
+ We need to account for the scroll position when calculating the root view rectangle in the screen.
+
+ * src/DateTimeChooserImpl.cpp:
+ (WebKit::DateTimeChooserImpl::writeDocument):
+
2012-10-29 Patrick Dubroy <[email protected]>
Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
Modified: branches/chromium/1312/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp (133742 => 133743)
--- branches/chromium/1312/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp 2012-11-07 13:35:35 UTC (rev 133742)
+++ branches/chromium/1312/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp 2012-11-07 13:42:44 UTC (rev 133743)
@@ -93,6 +93,7 @@
FrameView* view = static_cast<WebViewImpl*>(m_chromeClient->webView())->page()->mainFrame()->view();
IntRect rootViewVisibleContentRect = view->visibleContentRect(true /* include scrollbars */);
IntRect rootViewRectInScreen = m_chromeClient->rootViewToScreen(rootViewVisibleContentRect);
+ rootViewRectInScreen.move(-view->scrollX(), -view->scrollY());
addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer);
writer.addData(WebCore::pickerCommonCss, sizeof(WebCore::pickerCommonCss));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
